search

abrensch / brouter

configurable OSM offline router with elevation awareness, Java + Android
MIT License
494 stars 118 forks source link

NullPointerException thow in VoiceHintProcessor class #603

Closed oruxmanpower closed 5 months ago

oruxmanpower commented 1 year ago

With some frequently used .rd5 segment files in Korea, a NullPointerException is thrown at this point in the code:

https://github.com/abrensch/brouter/blob/master/brouter-core/src/main/java/btools/router/VoiceHintProcessor.java#L253

In other parts of the code the VoiceHint.badWays property is checked for nullity but at that point in the code it is not checked.

I don't know if at that point it should never be null, but the reality is that sometimes, with the aforementioned segment files, a NullPointerException is thrown.

afischerdev commented 1 year ago

Thanks for the pointer. We also have some errors collected by the Play Store. An update soon would be appropriate.