abrensch / brouter

configurable OSM offline router with elevation awareness, Java + Android
MIT License
476 stars 115 forks source link

Improve town, forest and river tags #614

Open quaelnix opened 11 months ago

quaelnix commented 11 months ago

Intended as a basis for discussion on the further development of the pseudo tags:

Before After

Example: https://brouter.de/brouter-web/#map=12/50.1407/8.7074/...profile=fastbike (with consider_town enabled)

quaelnix commented 11 months ago

I couldn't test the fine tuning at the moment.

This draft is not about fine-tuning. It is about fixing some of the most frustrating flaws in the current logic, and beyond that, untangling the city, forest, and river tags to give profile creators the freedom to nest them together as needed.


The current situation in three pictures:

Example 1 Example 2 Example 3
estimated_town_class=3 estimated_town_class= estimated_forest_class=2
quaelnix commented 10 months ago

@EssBee59, this PR fixes the problem shown in Example 1 by subtracting meadow and farmland landuse polygons from the town polygon, the one shown in Example 2 by greatly decreasing the lower population limit (I would prefer 1k as lower limit) and the one shown in Example 3 by only subtracting ways which are inside of green areas (this might need some more fine-tuning).

The performance overhead is definitely manageable and should not be the reason to not fix these problems.

If you have other ideas on how to fix them, please let me know.