abrensch / brouter

configurable OSM offline router with elevation awareness, Java + Android
MIT License
473 stars 113 forks source link

Replace multiple occurrences of toLowerCase() - continued #621

Closed afischerdev closed 9 months ago

afischerdev commented 10 months ago

Update with rework as discussed in #616: removed trim, renamed variable back to value, added new parse character.

quaelnix commented 10 months ago

What about these errors in the build log?

BExpressionContext.java:572: error: unmappable character (0xA0) for encoding UTF-8

            //value = value.replaceAll("�", ""); // nbsp
                                        ^ 
BExpressionContext.java:573: error: unmappable character (0x92) for encoding UTF-8
            value = value.replaceAll("�", "'");
                                      ^ 
BExpressionContext.java:574: error: unmappable character (0x94) for encoding UTF-8
            value = value.replaceAll("�", "\"");
                                      ^
quaelnix commented 10 months ago

My suggestion would be to split these changes as follows:

  1. Commit: Everything related to the toLowerCase() logic
  2. Commit: Everything related to the trim() logic
  3. Commit: Everything related to the replace(...) lobic
  4. Commit: Change in the - logic
quaelnix commented 10 months ago

:+1: