search

abrensch / brouter

configurable OSM offline router with elevation awareness, Java + Android
MIT License
473 stars 113 forks source link

App: Added more strings in resources #650

Closed afischerdev closed 5 months ago

afischerdev commented 7 months ago

Moved more hardcoded strings to resource. Initial pull request was #645 Please note: this contains no translations.

devemux86 commented 7 months ago

@afischerdev very nice, there are a lot of strings!

Please use String.format(...) with the positional arguments as seen here.

afischerdev commented 7 months ago

@devemux86

Please use String.format(...)

Thanks for the suggestion. I started that way but getString with parameter was working as well. Why do you think this is a better way?

devemux86 commented 7 months ago

@afischerdev

Although the other method is Android specific, Android shows warnings when we build a release apk. So I had to use in the other pull request the known Java method which passes all tests without issues.

afischerdev commented 7 months ago

@devemux86 Ok, I'll have an eye on that.

devemux86 commented 6 months ago

@afischerdev there are more texts we need to move to strings.xml: