search

abrensch / brouter

configurable OSM offline router with elevation awareness, Java + Android
MIT License
494 stars 117 forks source link

Fix 'sees' typo in consider_river switch #660

Closed waldyrious closed 8 months ago

waldyrious commented 8 months ago

Replace "rivers or sees" with "rivers, lakes, etc.", based on wording proposed by @gnbl in https://github.com/nrenner/brouter-web/issues/747.

quaelnix commented 8 months ago

@afischerdev, the profiles on the server apparently have not been updated for months. Could we sync them?

afischerdev commented 8 months ago

@quaelnix I'll try that, have never done it before and don't know if my rights will work for that.

But we should do a minimal change: set the default new in

trekking.brf
assign   ignore_cycleroutes  = true

as discussed e.g. here. That seems to be the main concern. All the other pending things could be discussed later on.

quaelnix commented 8 months ago

But we should do a minimal change: set the default new in

Why should we do that? There is even a dedicated trekking profile for exactly that case on the brouter.de server: https://brouter.de/brouter-web/#map=7/51.011/10.015/standard,route-quality&profile=trekking-ignore-cr

I might have overreacted a bit in that pull request, but disabling ignore_cycleroutes by default makes zero sense.

afischerdev commented 8 months ago

@quaelnix You are right. I always forget that feature. I only use the plain versions and so I always get a little irritated when I encounter the ignore_routes parameter..