search

abrensch / brouter

configurable OSM offline router with elevation awareness, Java + Android
MIT License
511 stars 122 forks source link

Minor changes for french language #698

Closed alkino closed 6 months ago

alkino commented 6 months ago

The main one is Gratuit > Libre Gratuit means free as in free beer. Libre means free as in available place.

devemux86 commented 6 months ago

@alkino

Thanks, may I ask about why inserting a space before the punctuation marks?

alkino commented 6 months ago

Because in french this is not correct to not insert one.

https://en.wikipedia.org/wiki/History_of_sentence_spacing#French_and_English_spacing

French spacing inserted spaces around most punctuation marks, but single-spaced after sentences, colons, and semicolons.

This is really a typographic mistake to not add one.

devemux86 commented 6 months ago

@alkino then is it needed a non-breaking space to avoid line break with punctuation mark alone in next line?

 

alkino commented 6 months ago

Yes, it would be better.

afischerdev commented 6 months ago

May be a   could do the job.

afischerdev commented 6 months ago

@alkino Your PR has not passed the build process. Please see here Do you like to complete it?