search

abrensch / brouter

configurable OSM offline router with elevation awareness, Java + Android
MIT License
511 stars 122 forks source link

New voicehints for motorway exit #742

Open afischerdev opened 1 week ago

afischerdev commented 1 week ago

This is the PR for #734

The problem with this new voicehints is, not all clients are ready for using. First rule: the export contains what the clients can read. Means

For testing select you favorite turnInstructionMode. Please use for a direct test export the button between close and export. When using JSON export you could select turnInstructionMode = 2 to get the new index.

For OsmAnd exists a special turnInstructionMode = 8. This is not reachable via the profile dialog, you have to set this inside the profile editor. It can be used to prepare OsmAnd to the new voicehints before BRouter delivers the new tags on turnInstructionMode = 3.

A Test is possible on the test server: route

@devemux86 @vshcherb @vodie @menion Please let us know when you change your rules in your apps, so we can go on to normalize the voicehint situation.

devemux86 commented 1 week ago

@afischerdev

Please use for a direct test export the button between close and export.

Can you explain what is the difference between the middle "cloud" button and the export button?

afischerdev commented 1 week ago

@devemux86 The export uses the web client internal export, the cloud button exports without reworking.

devemux86 commented 1 week ago

@afischerdev I have seen that GPX navigation tracks can only be exported with the middle "cloud" button. (and turnInstructionMode 2)

devemux86 commented 6 days ago

@afischerdev Thanks for this implementation. :+1:

Does the test server need a restart? Routing returns "502 Bad Gateway".

afischerdev commented 6 days ago

Just restarted

afischerdev commented 5 days ago

Just add a logic that also find motorway exits when there are no more entries. Therefore I added an new END voicehint type and throw it away after calculation. This is also already available on testserver.

devemux86 commented 5 days ago

@afischerdev

Should the clients do something with this? Or it is handled internally and is mapped to the EL / ER instructions?

afischerdev commented 5 days ago

@devemux86 It was only an internal update to get more exit nodes. As before the client only has to handle the new voicehints.

devemux86 commented 5 days ago

@afischerdev

As before the client only has to handle the new voicehints.

You mean the 2 new EL + ER instructions. (not the END)

afischerdev commented 5 days ago

@devemux86 Yes, this is only for temporary and internal use (discussable).

menion commented 5 days ago

Thanks @afischerdev , VoiceHint commands 17 EL and 18 ER support will be added to the Locus Map platform.