abresler / nbastatR

NBA Stats API Wrapper and more for R
http://asbcllc.com/nbastatR
309 stars 77 forks source link

get_days_nba_score() not working #14

Closed batpigandme closed 5 years ago

batpigandme commented 5 years ago

Hey Alex,

get_days_nba_score() isn't working today (I run it on the daily, so it was definitely working yesterday). This happened both before and after I updated, so I'm not sure it has to do with a change on your end.

reprex

library(nbastatR, warn.conflicts = FALSE)
yest_scores <- get_days_nba_scores(game_dates = "2018-10-24")
#> Getting NBA game details for 2018-10-24
#> Warning: Unknown or uninitialised column: 'nameTable'.

Created on 2018-10-25 by the reprex package (v0.2.1.9000)

Session info ``` r devtools::session_info() #> ─ Session info ────────────────────────────────────────────────────────── #> setting value #> version R version 3.5.1 (2018-07-02) #> os macOS Sierra 10.12.6 #> system x86_64, darwin15.6.0 #> ui X11 #> language (EN) #> collate en_US.UTF-8 #> ctype en_US.UTF-8 #> tz America/New_York #> date 2018-10-25 #> #> ─ Packages ────────────────────────────────────────────────────────────── #> package * version date lib #> assertthat 0.2.0 2017-04-11 [1] #> backports 1.1.2 2017-12-13 [1] #> base64enc 0.1-3 2015-07-28 [1] #> callr 3.0.0 2018-08-24 [1] #> cli 1.0.1 2018-09-25 [1] #> codetools 0.2-15 2016-10-05 [1] #> crayon 1.3.4 2017-09-16 [1] #> curl 3.2 2018-03-28 [1] #> debugme 1.1.0 2017-10-22 [1] #> desc 1.2.0 2018-05-01 [1] #> devtools 2.0.0 2018-10-19 [1] #> digest 0.6.18 2018-10-10 [1] #> dplyr 0.7.99.9000 2018-10-25 [1] #> evaluate 0.12 2018-10-09 [1] #> fs 1.2.6 2018-08-23 [1] #> furrr 0.1.0 2018-05-16 [1] #> future 1.10.0 2018-10-17 [1] #> globals 0.12.4 2018-10-11 [1] #> glue 1.3.0 2018-08-23 [1] #> highr 0.7 2018-06-09 [1] #> hms 0.4.2.9001 2018-08-22 [1] #> htmltools 0.3.6 2017-04-28 [1] #> httr 1.3.1 2017-08-20 [1] #> jsonlite 1.5 2017-06-01 [1] #> knitr 1.20.21 2018-10-23 [1] #> listenv 0.7.0 2018-01-21 [1] #> lubridate 1.7.4 2018-04-11 [1] #> magrittr 1.5 2014-11-22 [1] #> memoise 1.1.0 2017-04-21 [1] #> nbastatR * 0.1.11101 2018-10-25 [1] #> pillar 1.3.0.9001 2018-10-17 [1] #> pkgbuild 1.0.2 2018-10-16 [1] #> pkgconfig 2.0.2 2018-08-16 [1] #> pkgload 1.0.1 2018-10-11 [1] #> prettyunits 1.0.2 2015-07-13 [1] #> processx 3.2.0 2018-08-16 [1] #> ps 1.2.0 2018-10-16 [1] #> purrr * 0.2.5 2018-05-29 [1] #> R6 2.3.0 2018-10-04 [1] #> Rcpp 0.12.19.3 2018-10-15 [1] #> readr 1.2.0 2018-10-25 [1] #> remotes 2.0.1 2018-10-19 [1] #> rlang 0.3.0.9000 2018-10-25 [1] #> rmarkdown 1.10 2018-06-11 [1] #> rprojroot 1.3-2 2018-01-03 [1] #> rvest 0.3.2 2016-06-17 [1] #> sessioninfo 1.1.0.9001 2018-10-08 [1] #> stringi 1.2.4 2018-07-20 [1] #> stringr 1.3.1 2018-05-10 [1] #> testthat 2.0.1 2018-10-13 [1] #> tibble 1.4.99.9005 2018-10-25 [1] #> tidyr 0.8.1.9000 2018-10-25 [1] #> tidyselect 0.2.5 2018-10-11 [1] #> usethis 1.4.0.9000 2018-10-03 [1] #> withr 2.1.2 2018-03-15 [1] #> xfun 0.3 2018-07-06 [1] #> xml2 1.2.0 2018-01-24 [1] #> yaml 2.2.0 2018-07-25 [1] #> source #> CRAN (R 3.5.0) #> CRAN (R 3.5.0) #> CRAN (R 3.5.0) #> CRAN (R 3.5.0) #> CRAN (R 3.5.0) #> CRAN (R 3.5.1) #> CRAN (R 3.5.0) #> CRAN (R 3.5.0) #> CRAN (R 3.5.0) #> CRAN (R 3.5.0) #> CRAN (R 3.5.1) #> CRAN (R 3.5.0) #> Github (tidyverse/dplyr@2ea8925) #> CRAN (R 3.5.0) #> CRAN (R 3.5.0) #> CRAN (R 3.5.0) #> CRAN (R 3.5.1) #> CRAN (R 3.5.1) #> Github (tidyverse/glue@4e74901) #> CRAN (R 3.5.0) #> Github (tidyverse/hms@979286f) #> CRAN (R 3.5.0) #> CRAN (R 3.5.0) #> CRAN (R 3.5.0) #> Github (yihui/knitr@6c61415) #> CRAN (R 3.5.0) #> CRAN (R 3.5.0) #> CRAN (R 3.5.0) #> CRAN (R 3.5.0) #> Github (abresler/nbastatR@658b57a) #> Github (r-lib/pillar@c5bf622) #> CRAN (R 3.5.0) #> CRAN (R 3.5.0) #> CRAN (R 3.5.1) #> CRAN (R 3.5.0) #> CRAN (R 3.5.0) #> CRAN (R 3.5.0) #> CRAN (R 3.5.0) #> CRAN (R 3.5.0) #> Github (RcppCore/Rcpp@a669a19) #> Github (tidyverse/readr@69c9fd3) #> CRAN (R 3.5.1) #> Github (r-lib/rlang@9d3e832) #> CRAN (R 3.5.0) #> CRAN (R 3.5.0) #> CRAN (R 3.5.0) #> Github (r-lib/sessioninfo@9645364) #> CRAN (R 3.5.0) #> CRAN (R 3.5.0) #> CRAN (R 3.5.0) #> Github (tidyverse/tibble@3b830a2) #> Github (tidyverse/tidyr@c318c31) #> CRAN (R 3.5.1) #> Github (r-lib/usethis@1e3c6a6) #> CRAN (R 3.5.0) #> CRAN (R 3.5.0) #> CRAN (R 3.5.0) #> CRAN (R 3.5.0) #> #> [1] /Library/Frameworks/R.framework/Versions/3.5/Resources/library ```

I've gotten Unknown or uninitialised column errors before and still had data returned, but not for this one. I appended the session info in case it's relevant. Let me know if there's anything I can do to help out, and I'll give it a shot over the weekend.

Thanks, as always, for this package!

batpigandme commented 5 years ago

Nevermind, it's the dev version of tibble that's breaking it!

sc0h0 commented 5 years ago

Hi Alex, experiencing the same.

Today installed nbastatR on my Digital Ocean machine and getting error on running get_days_nba_scores:

Error: could not find function "get_days_nba_scores"

Have had nbastatR installed on my local machine for > 6 months and was working fine until reinstalled nbastatR (today) and this recreated the error.

Thanks

abresler commented 5 years ago

Syntax changed, reinstall and use this function

http://asbcllc.com/nbastatR/reference/days_scores.html


Alex Bresler abresler@asbcllc.com

​www.asbcllc.com​

917-455-0239 (cell)

On Sat, Jan 12, 2019, 7:17 PM scotthorvath <notifications@github.com wrote:

Hi Alex, experiencing the same.

Today installed nbastatR on my Digital Ocean machine and getting error on running get_days_nba_scores:

Error: could not find function "get_days_nba_scores"

Have had nbastatR installed on my local machine for > 6 months and was working fine untill reinstalled nbastatR (today) and this recreated the error.

Thanks

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/abresler/nbastatR/issues/14#issuecomment-453793913, or mute the thread https://github.com/notifications/unsubscribe-auth/AAtM1AycB2rHXf-kxSpwkOH6PNUuaruFks5vColAgaJpZM4X6Ags .

sc0h0 commented 5 years ago

Working now, thanks again!

sc0h0 commented 5 years ago

Looks like days_scores(game_dates = "2019-04-08", include_standings = F, return_message = T, league = "NBA") isn't returning any games. Are there sometimes delays in the data coming through?

abresler commented 5 years ago

There werent games yesterday so there wont be any scores

batpigandme commented 5 years ago

😂 This panic happens to me every year during the March Madness final.

jaketroch commented 1 month ago

this started happening today.

`> # get games for today

today <- nbastatR::days_scores(game_dates = "2024-09-10", league="WNBA") Getting WNBA game details for 2024-09-10 Warning message: Unknown or uninitialised column: nameTable. `