Wyre Account ID is hardcoded

abridged / dao-help

Template created to facilitate Collab19, an international relief fund using Ethereum

https://collab19.live

11 stars 7 forks source link

Wyre Account ID is hardcoded #8

Open adklempner opened 4 years ago

adklempner commented 4 years ago

In flow Contract Wallet Flow, function node Purchase Eth, the Wyre account ID is hardcoded on line 4:

wyreLink =  `${wyreLink}?destCurrency=ETH&dest=${msg.payload.user.account.fields.account_address}&accountId=AC_8MAWQ88LVEA`

Instead, it should use the global variable wyre_account_id:

wyreLink =  `${wyreLink}?destCurrency=ETH&dest=${msg.payload.user.account.fields.account_address}&accountId=${global.get('wyre_account_id')}`

kedMertens commented 4 years ago

Hi! I'm participating in DAO Hack Month and would like to resolve that issue as a part of my project, it is ok? The project is aiming to propose additional features and some improvements of dao-help