search

abril / tokamak

template engine for hypermedia resources that provides a single DSL to generate several media types representations
Other
39 stars 11 forks source link

Object id compatible #7

Closed caelum closed 13 years ago

caelum commented 13 years ago

I don't know if this is a desired functionality: not removing object_id (thus avoiding the warning) in tokamak lookup. Does it make sense remove/not to remove object_id?

lfcipriani commented 13 years ago

usually in a blank slate we don't remove methods that we are going to need on object later during runtime. In this case, I wouldn't need object_id, so I remove it to avoid conflict with values attributes.

guilhermesilveira commented 13 years ago

Luiz, is it possible to reconsider this patch? There is another restfulie client using a branched version with this applied. There will be much more people with the warning than people using object_id in his representation, and you can always add a helper method.

lfcipriani commented 13 years ago

OK, I'll apply