search

abrochard / kubel

Emacs extension for controlling Kubernetes with limited permissions
GNU General Public License v3.0
259 stars 41 forks source link

Make vterm option in kubel-exec-pod opt-in #100

Closed PuercoPop closed 1 year ago

PuercoPop commented 1 year ago

The PR has two commits, the first one is uncontroversial, the interactive spec should be the first form in the function (with the possible exception of the a declare form iiuc), so we need to swap places with the call to (require 'vterm).

The second commit is something that, although I prefer, I can understand if its rejected. I dislike require forms outside of top-level forms, so I extracted the vterm related function to a separate file. I use vterm myself so I've verified the transient has the option available with the steps in the README.md. Although using vterm from kubel hasn't working for me though but that is out of scope for this PR.

lmkwyt

PuercoPop commented 1 year ago

Upon further reflection I think that it doesn't make much sense to move it to a separate file, instead I'll move the require to the kubel-vterm-setup function. I'll update the PR.

abrochard commented 1 year ago

Thank you for submitting this. I'm not a vterm user and I was scratching my head last week when debugging this. I agree that moving to a separate file isn't required. But I like the other changes!

PuercoPop commented 1 year ago

@abrochard I've updated the PR with what I had in mind. Is this aligned with what you had in mind?