search

abrochard / kubel

Emacs extension for controlling Kubernetes with limited permissions
GNU General Public License v3.0
259 stars 41 forks source link

Use kubectl version --output=json #113

Closed johnhamelink closed 10 months ago

johnhamelink commented 10 months ago

The version output is set to change for kubectl, this change makes use of the JSON output in order to avoid a breakage.

This change also removes the hardcoded kubectl command, instead relying on the kubel-kubectl variable.

abrochard commented 10 months ago

Thank you for submitting this! It seems the tests are failing. I think the json-read-from-string was introduced in emacs 27? And also not sure why that is also failing https://app.circleci.com/pipelines/github/abrochard/kubel/182/workflows/6fbec020-d039-4c3c-a86d-253427fc5b20/jobs/500

johnhamelink commented 10 months ago

Hey @abrochard, I think I just need to update the fixture data, one moment :)

johnhamelink commented 10 months ago

Ok, now the tests are matching up with what you are saying!

johnhamelink commented 10 months ago

@abrochard passing now! :)