search

abrochard / mermaid-mode

Emacs major mode for working with mermaid graphs https://mermaidjs.github.io/
GNU General Public License v3.0
187 stars 22 forks source link

mermaid-mode redefines ob-mermaid org-babel-execute:mermaid #17

Open nahuel opened 3 years ago

nahuel commented 3 years ago

Both mermaid-mode and ob-mermaid defines the org-babel-execute:mermaid function who controls the evaluation of org-mode mermaid src blocks. When loading both packages, the loading order will determine which one will be applied. This can be confusing. For example, if the mermaid-mode one is the active and you use the :theme parameter (supported by ob-mermaid but not by mermaid-mode), it will be silently ignored.

I think the correct thing to do is to integrate ob-mermaid with mermaid-mode or remove org-babel-execute:mermaid from mermaid-mode.

jaybarra commented 1 year ago

Workaround for now is to fix order of loading, or overwrite the local defun with the one from ob-mermaid