abrom / henkei

Read text and metadata from files and documents (.doc, .docx, .pages, .odt, .rtf, .pdf)

http://github.com/abrom/henkei

MIT License

74 stars 14 forks source link

Ruby 3.3.0 support #39

Closed jasonperrone closed 7 months ago

jasonperrone commented 7 months ago

Just a friendly reminder that needs to be tested for Ruby 3.3.0 and gemspec updated. Unfortunately, this one gem is holding me back from upgrading my app to 3.3.0.

jasonperrone commented 7 months ago

38

abrom commented 7 months ago

Hi @jasonperrone

I'd suggest you take a look at https://bundler.io/guides/git.html#:~:text=Installing%20a%20gem%20using%20git,setup%20. if you can't wait for a gem release.

No one is holding you up 😉

jasonperrone commented 7 months ago

@abrom sorry, I thought the required changes weren't even merged into any branch yet? That PR is still open.

abrom commented 7 months ago

Right.. so, per the docs I posted:

gem 'henkei', git: 'https://github.com/adriangohjw/henkei.git', branch: 'add-ruby-3.3-support'

The PR links to the fork of henkei and the branch the change is on 😉

abrom commented 7 months ago

I am going through that PR now if you can hold off.. but it's still not holding you up

jasonperrone commented 7 months ago

Oh I see. Thanks, @abrom . I mean, it's not holding me up to the point where I have to point to a specific branch. I can wait. 😊

abrom commented 7 months ago

Change has been released in v2.6.0.2