abrom / rocketchat-ruby

Ruby wrapper for RocketChat v1 REST API
MIT License
33 stars 24 forks source link

Enable user to archive and unarchive #10

Closed danischreiber closed 7 years ago

danischreiber commented 7 years ago

Adding additional functionality to the REST api gem. Allow users to archive and unarchive rooms. Please review ASAP.

reist commented 7 years ago

@danischreiber can you make the methods use room_option_hash? Both calls accept roomName as well. This'll also make the API more similar to the already existing calls.

danischreiber commented 7 years ago

Updated.

On Wed, Jul 12, 2017 at 1:55 PM, Boris Peterbarg notifications@github.com wrote:

@danischreiber https://github.com/danischreiber can you make the methods use room_option_hash? Both calls accept roomName as well. This'll also make the API more similar to the already existing calls.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/abrom/rocketchat-ruby/pull/10#issuecomment-314731917, or mute the thread https://github.com/notifications/unsubscribe-auth/AEWU-wfRHW56uIHHuO0enKLMiuG_MH32ks5sNKYWgaJpZM4OVbQL .