abrom / rocketchat-ruby

Ruby wrapper for RocketChat v1 REST API
MIT License
33 stars 24 forks source link

Get unread count for user #18

Closed danischreiber closed 4 years ago

danischreiber commented 6 years ago

Thanks, I resubmitted the PR in rocketchat. We can wait to merge until it gets in.

On Sat, Sep 2, 2017 at 3:43 PM, Andrew Bromwich notifications@github.com wrote:

@abrom commented on this pull request.

Feature looks good @danischreiber https://github.com/danischreiber

Suggest we hold off merging this until the feature has been merged into the server api. That PR seems to be held up for a code format issue too??

In lib/rocket_chat/messages/user.rb https://github.com/abrom/rocketchat-ruby/pull/18#discussion_r136695192:

@@ -126,6 +126,21 @@ def info(user_id: nil, username: nil) end

   #
  • users.unread_count REST API

  • @param [String] user_id Rocket.Chat user id

  • @param [String] username Username

  • @return [User]

  • @raise [HTTPError, StatusError]

  • #
  • def unread_count(user_id: nil, username: nil)
  • response = session.request_json(
  • '/api/v1/users.unreadCount',

the build is wanting these two lines to be only indented once vs twice

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/abrom/rocketchat-ruby/pull/18#pullrequestreview-60275063, or mute the thread https://github.com/notifications/unsubscribe-auth/AEWU-8OZ5CVgP-q1c2yeSSjxjXbSDNZ7ks5seU2PgaJpZM4PF9Xf .

abrom commented 6 years ago

Hey @danischreiber, it looks like your PR in the rocketchat repo for this has gone stale?? Might be worth pinging them to get a review underway

abrom commented 5 years ago

Hey @danischreiber, still no movement on your PR in the rocketchat repo? I can't see the end-point in the users API.