search

abrom / rocketchat-ruby

Ruby wrapper for RocketChat v1 REST API
MIT License
33 stars 24 forks source link

Implemented Channels.list.joined api #23

Closed cloverhearts closed 5 years ago

cloverhearts commented 6 years ago

Rocket.chat api document.

Thank you :)

cloverhearts commented 6 years ago

Thank you for your review, i will check it :)

abrom commented 6 years ago

Reminder to also add some spec tests for this method. Take a look at https://github.com/abrom/rocketchat-ruby/blob/master/spec/messages/channel_spec.rb#L3 and https://github.com/abrom/rocketchat-ruby/blob/master/spec/messages/user_spec.rb#L239 for some inspiration

abrom commented 5 years ago

Hi @cloverhearts, have you been able to take a look at the specs for these changes??