search

abrom / rocketchat-ruby

Ruby wrapper for RocketChat v1 REST API
MIT License
33 stars 24 forks source link

users methods: resetAvatar and createToken #6

Closed reist closed 7 years ago

reist commented 7 years ago

Not sure what to do about the class line length. User doesn't even include all the API calls yet...

abrom commented 7 years ago

I'd just disable Metrics/LineLength on that class.

class User # rubocop:disable Metrics/LineLength

Could split the class up some more but I think that would make it less readable, not more

reist commented 7 years ago

ClassLength, but I agree. Splitting the file along arbitrary limits wouldn't help understanding.

By the way, https://github.com/RocketChat/Rocket.Chat.Docs/pull/324 Hope they merge it quickly.

abrom commented 7 years ago

Oops, yes you're right 👍