search

abrt / faf

Platform for collection and analysis of packages and package crashes
GNU General Public License v3.0
46 stars 47 forks source link

Use API key for Bugzilla authentication #1016

Closed mgrabovsky closed 1 year ago

michalfabik commented 1 year ago

The changes look good to me but seeing you also made changes to tests, how do I run those locally? Trying make check made me install many python packages until I ran into ERROR:faf: Unable to import plugin pyfaf.actions.fedmsg_notify: No module named 'faf_schema' with nowhere to install it from. Is this even supposed to work? I remember FAF's always been trick to test (having it installed locally broke the tests or something) but I don't remember the details.

mgrabovsky commented 1 year ago

Honestly, I don't bother with testing locally anymore. I used to run the tests in a container or via Mock, but now I just submit the PR and wait for Copr. The build in faf-el8-devel Copr passes for all OSes except for Fedora 37, but I'm not quite sure what the problem is:

Error: 
 Problem: cannot install the best candidate for the job
  - nothing provides python(abi) = 3.10 needed by python3-wtforms-sqlalchemy-0.3.0-1.fc37.noarch
  - nothing provides python3.10dist(sqlalchemy) >= 0.7.10 needed by python3-wtforms-sqlalchemy-0.3.0-1.fc37.noarch
  - nothing provides python3.10dist(wtforms) >= 1.0.5 needed by python3-wtforms-sqlalchemy-0.3.0-1.fc37.noarch
(try to add '--skip-broken' to skip uninstallable packages or '--nobest' to use not only best candidate packages)

Copr build error: Build failed

The test GitHub action is also broken because of some PostgreSQL shenanigans. I've been meaning to look into fixing it, but haven't got around to do it yet.

msrb commented 1 year ago

The build in faf-el8-devel Copr passes for all OSes except for Fedora 37, but I'm not quite sure what the problem is

I think this is fine. EPEL is (AFAIK) how FAF is being deployed right now (known instances).