Fix two bugs in handling of RPM headers

mgrabovsky commented 3 years ago

These changes fix a few bugs in faf_rpm which made reposync unusable a while ago:

Skip Provides longer than 1024 characters when storing dependencies from RPM headers.
Skip misformatted Provides instead of trying to roll back the whole transaction.
Moreover, only store Provides items in the database since we never use either of the other two (Requires or Conflicts).

We should migrate away from autocommit eventually, though it's not yet clear to me what the practical implications are.

See commits for details.

Fixes #943 Fixes #958

mgrabovsky commented 3 years ago

This is going to need a bit more polishing in the related tests.

mgrabovsky commented 3 years ago

Ready for review now.

msrb commented 3 years ago

Ouch... these types of bugs are the worst. Thanks for looking into it @mgrabovsky :wink:

Review in progress now...

msrb commented 3 years ago

Looks good to me, but my knowledge of the code base is very very limited.

michalfabik commented 3 years ago

Looks good to me, LGTM.

abrt / faf