search

abrt / gnome-abrt

ABRT oopses list designed according to https://live.gnome.org/Design/Apps/Oops
GNU General Public License v3.0
18 stars 21 forks source link

Epiphany crashes still get assigned to web apps #106

Open mcatanzaro opened 9 years ago

mcatanzaro commented 9 years ago

You pushed some commits to deal with this a few months ago, but apparently they don't work, as Epiphany crashes are still being reported as web app crashes in gnome-abrt-1.0.0-1.fc21. Here an Epiphany crash was misattributed to a web app I have installed, which was not running at the time of the crash.

screenshot from 2015-01-05 15 58 06

$ cat .local/share/applications/epiphany-duolingo-55f0d44bf9217fa2c4eaf7c958f50dcd257d4e05.desktop [Desktop Entry] Name=duolingo Exec=epiphany --application-mode --profile="/home/mcatanzaro/.config/epiphany/app-epiphany-duolingo-55f0d44bf9217fa2c4eaf7c958f50dcd257d4e05" https://www.duolingo.com/ StartupNotify=true Terminal=false Type=Application Icon=/home/mcatanzaro/.config/epiphany/app-epiphany-duolingo-55f0d44bf9217fa2c4eaf7c958f50dcd257d4e05/app-icon.png StartupWMClass=epiphany-duolingo-55f0d44bf9217fa2c4eaf7c958f50dcd257d4e05

jfilak commented 9 years ago

@Catanzaro Please provide also "cmdline" from the Details.

mcatanzaro commented 9 years ago

It's simply "epiphany"

screenshot from 2015-01-06 13 41 39

hadess commented 9 years ago

I just tested this by doing a "kill -SEGV XXX" where XXX was the PID of the web app, and it assigned the .desktop properly.

hadess commented 9 years ago

And after making a stock epiphany crash, and restarting gnome-abrt, the original crasher got assigned to another webapp, and the epiphany crash also got assigned to that other webapp.

The C code I ported from gnome-abrt to abrt-applet had the same bug.

hadess commented 9 years ago

I think that the problem is with abrt itself. Once it's done its de-duplication, we don't end up with 2 crashers, but a single one, for the same binary. Restarting gnome-abrt merged the 2 problems, and cmdline is that of the webapp...

hadess commented 9 years ago

I think that the problem is deeper than just gnome-abrt. Problem is:

hadess commented 9 years ago

At least adding the cmdline to the Crash() signal would mean that abrt-applet could get the "restart application" notification right. I have no idea how to get epiphany/web apps crashers merged in gnome-abrt though.