abrt / gnome-abrt

ABRT oopses list designed according to https://live.gnome.org/Design/Apps/Oops
GNU General Public License v3.0
18 stars 21 forks source link

spec: Add python3-beautifulsoup4 dependency #275

Closed ernestask closed 4 years ago

ernestask commented 4 years ago

Fallout from 837cb787caa4667a928673353e4ea8205ef9419a.

https://bugzilla.redhat.com/show_bug.cgi?id=1836634 https://bugzilla.redhat.com/show_bug.cgi?id=1836738

packit-as-a-service[bot] commented 4 years ago

Congratulations! One of the builds has completed. :champagne:

You can install the built RPMs by following these steps:

Please note that the RPMs should be used only in a testing environment.

mgrabovsky commented 4 years ago

Should this be added to meson.build as well? Or does it not care about such earthly matters?

ernestask commented 4 years ago

I’m not sure where it’s needed during the build.

xsuchy commented 4 years ago

I guess that it is needed as well, but we have in %check || :

ernestask commented 4 years ago

Well, really, most of the Python build dependencies in the spec file are bogus, because we neither have the tests, nor are they used in building the CPython wrapper.

I could write some kind of regression test for this and then we would use some of them.