abrt / retrace-server

Application for remote coredump analysis
GNU General Public License v2.0
40 stars 30 forks source link

retrace-server-task: Improve verbose error message when 'create' fails #441

Closed DaveWysochanskiRH closed 3 years ago

DaveWysochanskiRH commented 3 years ago

When the 'create' command fails due to some error on the server such as a certificate problem, today we don't print any more information but just print "Could not connect to server". Improve debugging when connections fail by printing the string value of the requests exception.

Before this patch: $ retrace-server-task create -v ./vmcore INFO:root:Defaulting to manager task INFO:root:Trying to connect to ‘https://retrace.example.com’... DEBUG:urllib3.connectionpool:Starting new HTTPS connection (1): retrace.example.com:443 INFO:root:Could not connect to server ‘https://retrace.example.com’. Falling back to ‘https://retrace.fedoraproject.org

After this patch: $ ./retrace-server-task create -v ./vmcore INFO:root:Defaulting to manager task INFO:root:Trying to connect to ‘https://retrace.example.com’... DEBUG:urllib3.connectionpool:Starting new HTTPS connection (1): retrace.example.com:443 ERROR:root:Requests generic exception: 'HTTPSConnectionPool(host='retrace.example.com', port=443): Max retries exceeded with url: / (Caused by SSLError(SSLError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:897)'),))' ERROR:root:Could not connect to server ‘https://retrace.example.com’. Falling back to ‘https://retrace.fedoraproject.org

Signed-off-by: Dave Wysochanski dwysocha@redhat.com