search

abrt / retrace-server

Application for remote coredump analysis
GNU General Public License v2.0
40 stars 30 forks source link

Replace TASK_RETRACE with TASK_COREDUMP for consistency #447

Closed DaveWysochanskiRH closed 2 years ago

DaveWysochanskiRH commented 2 years ago

In retrace-server there are userspace coredumps and kernel vmcores. The kernel vmcores have tasks identified by TASK_VMCORE and TASK_VMCORE_INTERACTIVE. However, userspace coredumps are identified with TASK_RETRACE and TASK_RETRACE_INTERACTIVE, which is inconsistent and ambigous. Thus, rename TASK_RETRACE and TASK_RETRACE_INTERACTIVE to TASK_COREDUMP and TASK_COREDUMP_INTERACTIVE. In addition, correct one typo in doc/retrace-server.texi.

Signed-off-by: Dave Wysochanski dwysocha@redhat.com

DaveWysochanskiRH commented 2 years ago

NOTE: This patch should be no functional change, but I was unable to test it due to lack of coredump support on our servers.

DaveWysochanskiRH commented 2 years ago

@mgrabovsky can this be merged or is it still under review / test?

michalfabik commented 2 years ago

@mgrabovsky, feel free to merge. I read through it already but I figured you'd want to see it too since you're more familiar with retrace-server.

mgrabovsky commented 2 years ago

There's one more place where you could change this: in retrace_worker.py we have the function start_retrace() which could be renamed to something like start_coredump() per this scheme.

DaveWysochanskiRH commented 2 years ago

There's one more place where you could change this: in retrace_worker.py we have the function start_retrace() which could be renamed to something like start_coredump() per this scheme.

Good point! Will fixup and re-push.

mgrabovsky commented 2 years ago

Great. Thanks.