config: Add support for RAR archives if the unar tool is installed

[DaveWysochanskiRH]

If 'unar' tool is installed we can extract 'rar' archives, which is a rare, but not non-existent, archive type.

Make this an optional install for meson to prevent build failures. If not installed, but a RAR archive is submitted, the task will fail with something like the following in retrace_log: [D] File type: rar archive data, v4, os: win32 [D] rar detected [W] [Errno 2] No such file or directory: 'unar': 'unar'

Resolves: https://github.com/abrt/retrace-server/issues/465 Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1457434 Signed-off-by: Dave Wysochanski dwysocha@redhat.com

[codecov-commenter]

Codecov Report

Merging #466 (90a2183) into master (5e87145) will decrease coverage by 0.01%. The diff coverage is 16.66%.

@@            Coverage Diff             @@
##           master     #466      +/-   ##
==========================================
- Coverage   21.98%   21.97%   -0.02%     
==========================================
  Files          18       18              
  Lines        2847     2853       +6     
==========================================
+ Hits          626      627       +1     
- Misses       2221     2226       +5     

Flag	Coverage Δ
unittests	21.97% <16.66%> (-0.02%)	:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/retrace/archive.py	16.27% <16.66%> (-0.49%)	:arrow_down:
build/src/retrace/config.py	44.61% <0.00%> (+0.86%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5e87145...90a2183. Read the comment docs.

[lgtm-com[bot]]

This pull request introduces 1 alert when merging 90a21835b33b7601e97e67bf985372dbf4d86b65 into 5e87145bcaf74bf3a6fbbf398770a8a3f0f1c4e7 - view on LGTM.com

new alerts:

• 1 for Unused import

[DaveWysochanskiRH]

Guess I missed mime type code - oops!

[DaveWysochanskiRH]

NOTE: I did not believe my testing covers the MIME code paths. I believe this code is only called from the "unpack()" method which is called from src/create.wsgi. The only caller of 'create' POST method in the code is retrace-server-task, and it does not use arbitrary MIME types.

I'm not sure if there's another tool which uses that, or some other method of testing that could be used, but it seems this is not a used code path for our retrace-server implementations, unless I'm overlooking something.