search

abrt / satyr

Automatic problem management with anonymous reports
GNU General Public License v2.0
19 stars 22 forks source link

Potential issue with GNOME crashes that run through `dump_gjs_stack_on_signal_handler` #272

Closed AdamWill closed 6 years ago

AdamWill commented 6 years ago

GNOME Shell was recently tweaked to dump the gjs stack when it crashes. I found one crash report which hit this codepath and looks slightly wrong: https://bugzilla.redhat.com/show_bug.cgi?id=1517009 .

Note that the truncated backtrace is very truncated: it's cut off after the dump_gjs_stack_on_signal_handler . I'm not totally sure how the 'truncation' feature of abrt/satyr/libreport relates to the 'duplicate detection' feature, but if a comparison of truncated backtraces is part of the duplicate detection, obviously there's a potential for false duplication there. This bug did indeed originally have several duplicates, which I went through and un-duplicated manually: https://bugzilla.redhat.com/show_bug.cgi?id=1526187 and https://bugzilla.redhat.com/show_bug.cgi?id=1525693 were two of those.

On the other hand, there are some reports with more typical 'truncated backtraces' that run through dump_gjs_stack_on_signal_handler but include several other frames too: https://bugzilla.redhat.com/show_bug.cgi?id=1525470 and https://bugzilla.redhat.com/show_bug.cgi?id=1525294 for instance.

I'm not sure what if any action abrt/satyr needs to take here beyond the other issues I've flagged recently, but figured this one was at least worth mentioning. Thanks!

mkutlak commented 6 years ago

This should be fixed with the PR #280