abrt / satyr

Automatic problem management with anonymous reports
GNU General Public License v2.0
19 stars 22 forks source link

style: Various fixes suggested by Clang #288

Closed mgrabovsky closed 5 years ago

mgrabovsky commented 5 years ago
mkutlak commented 5 years ago

Please split the commit to multiple ones. Each commit should cover one topic:

mgrabovsky commented 5 years ago

Commit split.

ernestask commented 5 years ago

Also, https://github.com/abrt/satyr/pull/288/commits/abb74839ea2c091a33e88192c123088615208585 could be squashed with https://github.com/abrt/satyr/pull/288/commits/5b278d4b45142f667fdbd185587d4c5b2748bf51, since you’re doing the same, essentially.

ernestask commented 5 years ago

Otherwise LGTM.

mgrabovsky commented 5 years ago

OK, should be fine now.