search

abrt / satyr

Automatic problem management with anonymous reports
GNU General Public License v2.0
19 stars 22 forks source link

git repo does not contain ./satyr-version #296

Closed kloczek closed 4 years ago

kloczek commented 4 years ago

By this is not possible to download tar ball from tag and use it.

That tar (current one https://github.com/abrt/satyr//archive/0.29/satyr-0.29.tar.gz) is not with git data.

Suggestion: remove autogen.sh content replace it with one command "autoreconf -fiv". After remove many lines in Makefile.am all what it would be necessary is maintain version in first line of the configure.ac.

kloczek commented 4 years ago

Here is example what can be done. satyr-simplifications.patch.txt

ernestask commented 4 years ago

Not sure what you’re doing, but that tarball is literally what you get from git-archive. I’m not exactly inclined to generate distribution ones and upload them by hand every time.

ernestask commented 4 years ago

The versioning will also stay as-is until we can move to Meson and simplify things even more.

kloczek commented 4 years ago

I have implemented build procedure which does not rely on you tar balls generated by dist/distcheck targets. This allows me to build satyr package using any point of commit.