tests: Finish moving away from Autotest

[michalfabik]

This commit finishes what c465acea started. The Python binding testsuite is left as-is so it isn't included in the check-valgrind make target. Also, drop the old maintainer-check-valgrind make target as it's no longer needed.

Signed-off-by: Michal Fabik mfabik@redhat.com

[michalfabik]

I pushed three more commits with leak fixes in actual satyr code. There's one last 3-byte leak in the operating_system test that I can't figure out for the life of me. It only comes up when running the testsuite the usual way, which runs the .lib/lt-operating_system binary under valgrind. There are no leaks when running the operating_system binary under tests. I give up, feel free to have at it.

[mzidek-gh]

Some errors are left behind:

cluster.c:72:1: error: ‘test_dendrogram_cut_1’ defined but not used [-Werror=unused-function]
   72 | test_dendrogram_cut_1(void)
      | ^~~~~~~~~~~~~~~~~~~~~

And with make check-valgrind:

make[3]: Entering directory '/home/mzidek/gitrepo/satyr/tests'
  CC       cluster.o
cluster.c:72:1: error: ‘test_dendrogram_cut_1’ defined but not used [-Werror=unused-function]
   72 | test_dendrogram_cut_1(void)
      | ^~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
make[3]: *** [Makefile:957: cluster.o] Error 1
  CCLD     core_frame
  CC       core_stacktrace.o
core_stacktrace.c:206:1: error: ‘generate_coredump’ defined but not used [-Werror=unused-function]
  206 | generate_coredump(int start)
      | ^~~~~~~~~~~~~~~~~

[mzidek-gh]

Other then the unused functions it looks ok.

[michalfabik]

Some errors are left behind:

cluster.c:72:1: error: ‘test_dendrogram_cut_1’ defined but not used [-Werror=unused-function]
   72 | test_dendrogram_cut_1(void)
      | ^~~~~~~~~~~~~~~~~~~~~

And with make check-valgrind:

make[3]: Entering directory '/home/mzidek/gitrepo/satyr/tests'
  CC       cluster.o
cluster.c:72:1: error: ‘test_dendrogram_cut_1’ defined but not used [-Werror=unused-function]
   72 | test_dendrogram_cut_1(void)
      | ^~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
make[3]: *** [Makefile:957: cluster.o] Error 1
  CCLD     core_frame
  CC       core_stacktrace.o
core_stacktrace.c:206:1: error: ‘generate_coredump’ defined but not used [-Werror=unused-function]
  206 | generate_coredump(int start)
      | ^~~~~~~~~~~~~~~~~

When are you getting these? I'm running ./autogen.sh && ./ocnfigure && make, then make check and make check-valgrind and save for the one leftover valgrind issue, there are no errors. (I'm not disputing that these need to be fixed, of course.)

[mgrabovsky]

There's a typo in the main() of cluster.c: https://github.com/michalfabik/satyr/blob/finish-moving-away/tests/cluster.c#L173 The second arguments should be test_dendrogram_cut_1.

[michalfabik]

There's a typo in the main() of cluster.c: https://github.com/michalfabik/satyr/blob/finish-moving-away/tests/cluster.c#L173 The second arguments should be test_dendrogram_cut_1.

Yeah, that one I found already.