search

abrt / satyr

Automatic problem management with anonymous reports
GNU General Public License v2.0
19 stars 22 forks source link

configure doesn't check for elfutils #326

Closed yurivict closed 3 years ago

michalfabik commented 3 years ago

Hi, could you please provide a few more details as to what exactly the issue is? The elfutils package only provides binaries and satyr doesn't use any of those. We're checking for libdw which is provided by elfutils-devel. Perhaps you need the check for elfutils-devel to be explicit for some reason?

mzidek-gh commented 3 years ago

If this caused some error during build the logs would be useful so we know exactly what the issues is.

yurivict commented 3 years ago

It couldn't find elfutils' headers during build.

michalfabik commented 3 years ago

What system are you building on?

yurivict commented 3 years ago

FreeBSD.

yurivict commented 3 years ago

elfutils is in a package that needs to be installed.

michalfabik commented 3 years ago

Hi @yurivict, please see the PR above. I'm not quite sure what exactly it was that you needed to check for. IIRC, you were talking about an elfutils header but you edited the message in the meantime. I added a check for elfutils/version.h, since that's a header we're including from satyr code.

yurivict commented 3 years ago

configure should check that elfutils is installed. I ran configure - it succeeded. Thenn I ran build, and it failed because elfutils was missing. This is a bug IMO.

michalfabik commented 3 years ago

Could you please paste the output from the build?

On Linux, the elfutils package only contains the following: 

$ rpm -ql elfutils  
/usr/bin/eu-addr2line  
/usr/bin/eu-ar  
/usr/bin/eu-elfclassify  
/usr/bin/eu-elfcmp  
/usr/bin/eu-elfcompress  
/usr/bin/eu-elflint  
/usr/bin/eu-findtextrel  
/usr/bin/eu-make-debug-archive  
/usr/bin/eu-nm  
/usr/bin/eu-objdump  
/usr/bin/eu-ranlib  
/usr/bin/eu-readelf  
/usr/bin/eu-size  
/usr/bin/eu-stack  
/usr/bin/eu-strings  
/usr/bin/eu-strip  
/usr/bin/eu-unstrip  
$

And we aren't using any of those binaries. It would be good to know what specifically from the elfutils package you're missing. Or is there a way to check for a rpm (or whatever package management system) package with Autotools?