msrb commented 1 year ago

If we normalize the stacktrace, then we should also normalize the crash frame. Otherwise the normalized function name from the top thread frame doesn't have to match with the same function name in the crash frame.

Example: Normalized thread frame function name: poll Raw crash frame function name: GI___poll

Resolves: rhbz#2168223

Signed-off-by: Michal Srb michal@redhat.com

codecov-commenter commented 1 year ago

Codecov Report

Merging #336 (86e8e0b) into master (26aa206) will decrease coverage by 0.01%. The diff coverage is 77.77%.

:exclamation: Current head 86e8e0b differs from pull request most recent head 9f27298. Consider uploading reports for the commit 9f27298 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #336      +/-   ##
==========================================
- Coverage   63.13%   63.12%   -0.01%     
==========================================
  Files          40       40              
  Lines        7351     7355       +4     
  Branches     1232     1233       +1     
==========================================
+ Hits         4641     4643       +2     
  Misses       2180     2180              
- Partials      530      532       +2

Impacted Files	Coverage Δ
lib/normalize.c	`82.67% <77.77%> (-0.48%)`	:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

msrb commented 1 year ago

@mgrabovsky @michalfabik I am going to merge this (I tested it), but if you find any problems, I will be happy to address them in another PR ;)

mgrabovsky commented 1 year ago

Looks fine to me.

abrt / satyr

Normalize both gdb stacktrace and the crash frame #336

Codecov Report