msrb commented 1 year ago

When we normalize a stacktrace, we sometimes remove certain frames. The problem is when crash frame is one of those removed frames. In such cases, we simply cannot (reliably) find the crash thread.

Therefore, before we normalize the stacktrace, we look for the crash thread and remember its id. We can then use that id later, if needed.

Related: rhbz#2168223 Fixes: #337

Signed-off-by: Michal Srb michal@redhat.com

codecov-commenter commented 1 year ago

Codecov Report

Merging #338 (72d99bb) into master (a649a68) will decrease coverage by 0.01%. The diff coverage is 50.00%.

:exclamation: Current head 72d99bb differs from pull request most recent head a29f566. Consider uploading reports for the commit a29f566 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #338      +/-   ##
==========================================
- Coverage   63.12%   63.11%   -0.01%     
==========================================
  Files          40       40              
  Lines        7355     7359       +4     
  Branches     1233     1235       +2     
==========================================
+ Hits         4643     4645       +2     
  Misses       2180     2180              
- Partials      532      534       +2

Impacted Files	Coverage Δ
lib/normalize.c	`82.20% <50.00%> (-0.47%)`	:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

msrb commented 1 year ago

@mgrabovsky @michalfabik Anybody for a quick review? :)

abrt / satyr

Find crash thread before stacktrace is normalized #338

Codecov Report