Open dmitry-saritasa opened 6 years ago
on Python 3.5.2 all working correctly
on Python 3.5.5 type hints failed - i used Iterable(<type>)
, but this
not correct - correct using is Iterable[<type>]
fixed, pushed
2018-05-03 11:25 GMT+05:00 Dmitry Semenov notifications@github.com:
Hi Alexander,
thanks for submitting the test task, however on my side this is what I get
code/tests/BryazginAlexander on ξ master via π tests β pytest ================================ test session starts ================================= platform linux -- Python 3.5.5, pytest-3.5.1, py-1.5.3, pluggy-0.6.0 rootdir: /home/dmitry/Projects/tests/BryazginAlexander, inifile: collected 0 items / 4 errors
======================================= ERRORS ======================================= _____ ERROR collecting tests/test_example.py ___ tests/test_example.py:4: in
from route import RoutePoint, RouteRefuel src/route.py:81: in new(cls) E TypeError: Can't instantiate abstract class Iterable with abstract methods iter____ ERROR collecting tests/test_no_routes.py __tests/test_no_routes.py:5: inclass RouteManager: src/route.py:90: in RouteManager across_points: Iterable(MapPoint), ../../../.pyenv/versions/3.5.5/lib/python3.5/typing.py:1249: in new return _generic_new(cls.next_in_mro, cls, *args, **kwds) ../../../.pyenv/versions/3.5.5/lib/python3.5/typing.py:1210: in _generic_new return base_cls. from pathfinder import find_path, NoSolutionsrc/pathfinder.py:3: in from route import (src/route.py:81: in class RouteManager:src/route.py:90: in RouteManager across_points: Iterable(MapPoint),../../../.pyenv/versions/3.5.5/lib/python3.5/typing.py:1249: in new return _generic_new(cls.next_in_mro, cls, *args, kwds)../../../.pyenv/versions/3.5.5/lib/python3.5/typing.py:1210: in _generic_new return base_cls.new(cls)E TypeError: Can't instantiate abstract class Iterable with abstract methods iter __ ERROR collecting tests/test_two_gas_stations_for_use.py _____ tests/test_two_gas_stations_for_use.py:4: in from route import RoutePoint, RouteRefuel src/route.py:81: in new(cls) E TypeError: Can't instantiate abstract class Iterable with abstract methods iter_ ERROR collecting tests/test_with_across_points.py tests/test_with_across_points.py:4: inclass RouteManager: src/route.py:90: in RouteManager across_points: Iterable(MapPoint), ../../../.pyenv/versions/3.5.5/lib/python3.5/typing.py:1249: in new return _generic_new(cls.next_in_mro, cls, *args, **kwds) ../../../.pyenv/versions/3.5.5/lib/python3.5/typing.py:1210: in _generic_new return base_cls. from route import RoutePointsrc/route.py:81: in kwds)../../../.pyenv/versions/3.5.5/lib/python3.5/typing.py:1210: in _generic_new return base_cls.new(cls)E TypeError: Can't instantiate abstract class Iterable with abstract methods iter!!!!!!!!!!!!!!!!!!!!!! Interrupted: 4 errors during collection !!!!!!!!!!!!!!!!!!!!!!! ============================== 4 error in 0.30 seconds =============================== (tests) code/tests/BryazginAlexander on ξ master via π testsclass RouteManager:src/route.py:90: in RouteManager across_points: Iterable(MapPoint),../../../.pyenv/versions/3.5.5/lib/python3.5/typing.py:1249: in new return _generic_new(cls.next_in_mro, cls, *args, β You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bryazginnn/test-task-Very-Interesting/issues/1, or mute the thread https://github.com/notifications/unsubscribe-auth/AFc400gyUZpzOhn_2I1UmQJ6L1U-DxU8ks5tuqLTgaJpZM4TwjZW .
Hi Alexander,
thanks for submitting the test task, however on my side this is what I get