search

abs-tudelft / fletcher

Fletcher: A framework to integrate FPGA accelerators with Apache Arrow
https://abs-tudelft.github.io/fletcher/
Apache License 2.0
217 stars 31 forks source link

Use filesystem library to deal with paths (#140) #147

Closed johanpel closed 4 years ago

johanpel commented 5 years ago

Solves #140, but is a bit tricky in terms of compiler support.

Clang 7 and GCC 8 support it but they're not that mainstream yet, requiring users to perform some additional steps on default systems like Ubuntu.

Also GCC requires some flags, but apparently Clang doesn't (at least not on my system).

This would require a bit more investigation to support it nicely.

codecov[bot] commented 5 years ago

Codecov Report

Merging #147 into develop will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop    #147   +/-   ##
=======================================
  Coverage     88.1%   88.1%           
=======================================
  Files           50      50           
  Lines         4903    4903           
=======================================
  Hits          4320    4320           
  Misses         583     583

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a8f320b...45075f7. Read the comment docs.

johanpel commented 4 years ago

We could alternatively use arrows internal filesystem library since this is a dependency already anyway.

johanpel commented 4 years ago

This is now an issue in Cerata: https://github.com/abs-tudelft/cerata/issues/6