search

abs-tudelft / fletcher

Fletcher: A framework to integrate FPGA accelerators with Apache Arrow
https://abs-tudelft.github.io/fletcher/
Apache License 2.0
217 stars 31 forks source link

Remove deprecated attribute from runtime #152

Closed mbrobbel closed 5 years ago

mbrobbel commented 5 years ago

Looks like the function being deprecated was ImplementsSchema: https://github.com/abs-tudelft/fletcher/pull/142/files#diff-6dd2fd6b41501f23785a9adf44f73727L37

Since our api's are not stable yet, not explicitely deprecating this method is no issue.

I'm trying to build a platform runtime with gcc 4.8, and the [[deprecated]] attribute was added in 4.9: https://gcc.gnu.org/projects/cxx-status.html

johanpel commented 5 years ago

It's deprecated because it's not implemented yet, so it will generate a warning for users.

It depends on this issue because if we have this hash we can use it to put a hash in a register https://issues.apache.org/jira/browse/ARROW-2719