search

abs-tudelft / fletcher

Fletcher: A framework to integrate FPGA accelerators with Apache Arrow
https://abs-tudelft.github.io/fletcher/
Apache License 2.0
217 stars 31 forks source link

Pin all dependencies #214

Closed mbrobbel closed 3 years ago

mbrobbel commented 4 years ago

We're still using some unpinned dependencies which may cause build failures due to upstream changes. We should make sure that all dependencies are pinned.

johanpel commented 3 years ago

With the exception of dependencies on: https://github.com/abs-tudelft/cmake-modules.git there are currently no unpinned dependencies anymore. Would you like to pin it on the latest commit there or would you like to create a tag @mbrobbel ?

mbrobbel commented 3 years ago

With the exception of dependencies on: https://github.com/abs-tudelft/cmake-modules.git there are currently no unpinned dependencies anymore. Would you like to pin it on the latest commit there or would you like to create a tag @mbrobbel ?

Pinning to the lastest commit is fine 👍

johanpel commented 3 years ago

You know what, let's just make an exception for cmake-modules, it's stable and rarely changes. Saves us a bunch of commits if it ever does to fix a bug here or there. Hence I can close this.