search

abs-tudelft / fletcher

Fletcher: A framework to integrate FPGA accelerators with Apache Arrow
https://abs-tudelft.github.io/fletcher/
Apache License 2.0
217 stars 31 forks source link

Add date32, date64, decimal128 #222

Closed johanpel closed 4 years ago

johanpel commented 4 years ago

Noticed a few fixed-size types weren't supported yet. This adds support for Arrow's date32, date64 and decimal128

codecov[bot] commented 4 years ago

Codecov Report

Merging #222 into develop will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #222   +/-   ##
========================================
  Coverage    88.03%   88.03%           
========================================
  Files           50       50           
  Lines         4907     4907           
========================================
  Hits          4320     4320           
  Misses         587      587

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a42290a...bb891b9. Read the comment docs.

johanpel commented 4 years ago

Seems like there are a lot of deprecated functions in 0.16 that slipped through CI last time when we upgraded?

mbrobbel commented 4 years ago

Seems like there are a lot of deprecated functions in 0.16 that slipped through CI last time when we upgraded?

It looks like a mix of 0.16 and 0.17 artifacts was installed. Looks like the Arrow team are releasing 0.17. Because they don't seem to retain older releases (and we're not building from source in CI), we always get the latest version (because we have to apply a workaround), which causes these jobs to fail.

Setting up libarrow-glib-doc (0.17.0-1) ...
Setting up libarrow16:amd64 (0.16.0-1) ...
Setting up libarrow17:amd64 (0.17.0-1) ...
Setting up libgandiva-glib-doc (0.17.0-1) ...
Setting up libgandiva16:amd64 (0.16.0-1) ...
Setting up libgandiva17:amd64 (0.17.0-1) ...
Setting up libparquet-glib-doc (0.17.0-1) ...
Setting up libparquet16:amd64 (0.16.0-1) ...
Setting up libparquet17:amd64 (0.17.0-1) ...
Setting up libplasma-glib-doc (0.17.0-1) ...
Setting up libarrow-dataset16:amd64 (0.16.0-1) ...
Setting up libarrow-dataset17:amd64 (0.17.0-1) ...
Setting up libarrow-dev:amd64 (0.17.0-1) ...
Setting up libarrow-flight16:amd64 (0.16.0-1) ...
Setting up libarrow-flight17:amd64 (0.17.0-1) ...
Setting up libarrow-glib16:amd64 (0.16.0-1) ...
Setting up libarrow-glib17:amd64 (0.17.0-1) ...
Setting up libgandiva-dev:amd64 (0.17.0-1) ...
Setting up libgandiva-glib16:amd64 (0.16.0-1) ...
Setting up libgandiva-glib17:amd64 (0.17.0-1) ...
Setting up libparquet-dev:amd64 (0.17.0-1) ...
Setting up libparquet-glib16:amd64 (0.16.0-1) ...
Setting up libparquet-glib17:amd64 (0.17.0-1) ...
Setting up libarrow-dataset-dev:amd64 (0.17.0-1) ...
Setting up libarrow-flight-dev:amd64 (0.17.0-1) ...
johanpel commented 4 years ago

Easiest would be for us to migrate to 0.17 alongside Arrow, I'll do this some other time, so this might stay open for a bit

mbrobbel commented 4 years ago

@johanpel if you review + merge #223 and rebase this branch, it should be good to go.

johanpel commented 4 years ago

Going to fix this through #226