search

abs-tudelft / fletcher

Fletcher: A framework to integrate FPGA accelerators with Apache Arrow
https://abs-tudelft.github.io/fletcher/
Apache License 2.0
217 stars 31 forks source link

Add implicit "listprim" configuration code path for Arrow list of non-nullable primitives #226

Closed johanpel closed 4 years ago

johanpel commented 4 years ago

Some stuff was broken when attempting to use an Arrow list of non-nullable primitives. This should have been converted to a "listprim" ArrayReader/Writer as for the Arrow UTF8 and BINARY types, but it seems the code path was never completed. This PR adds the code path and a test. Also adds some new fixed-width types that have appeared over time.

codecov[bot] commented 4 years ago

Codecov Report

Merging #226 into develop will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #226   +/-   ##
========================================
  Coverage    88.03%   88.03%           
========================================
  Files           50       50           
  Lines         4907     4907           
========================================
  Hits          4320     4320           
  Misses         587      587

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update aaee6a1...0e86e08. Read the comment docs.