absalom-muc / MHI-AC-Ctrl

Reads and writes data (e.g. power, mode, fan status etc.) from/to a Mitsubishi Heavy Industries (MHI) air conditioner (AC) via SPI controlled by MQTT
MIT License
270 stars 61 forks source link

Wrong assembly orientation of X1 in KiCad PCB layout #111

Closed absalom-muc closed 1 year ago

absalom-muc commented 1 year ago

@oliv3r : Not sure if you have seen my question in your KiCad pull request.

grafik

I believe the orientation of X1 is not correct and should be rotated by 180°. Could you recheck?

oliv3r commented 1 year ago

Hey @absalom-muc,

don't think so? I took this picture of you as reference: image obviously this is the male mounted at the bottom, but the 'tabs' are pointing the same way, board-inside. I agree that the actual connector is on the wrong side and uses the wrong model :p but that shouldn't matter? Though when you are using a female socket, and an extension cable, I'd still expect the model to be correct actually? So it should use the same layout/orientation as the AC PCB, and a 1:1 extension cable should fit perfectly.

Looking at the pcblayout: image GND is pin 1 facing the 'middle' +12V is the bottom one facing the edge. As I 'traced' your PCB, I'm fairly confident that the pin orientation is identical to yours?

So pins are GND, MISO, MOSI, CLK, 12V which is exactly what you had as well (though no silkscreen helpers on those labels :p)

absalom-muc commented 1 year ago

Hello @oliv3r , X1 should be a female mounted at the bottom to plug directly on the AC PCB. And the extension cables I found to buy have a male connector on one side and a female connector on the other side wth 1:1 connection. For using this extension cable with the female connector on the top, X1 should be rotated by 180° so that the 2 tabs point outwards.

I don't know if you can buy an extension cable with female connectors on both sides needed for your configuration And if such an extension cable exists if the connector pins are swapped.

What do you think?

oliv3r commented 1 year ago

Well right now the connector is just a render, and the pinout matches exactly that of a female (the housing is male?) on the bottom. So if you'd solder this board, and put the correct connector on the bottom with the edges facing inwards, your fine.

If I 'flip' the connector to the bottom, it looks like this: image

But regardless, the pinout stays completly identical. So in the end, it's just how the component is being rendered. I do agree it makes logically more sense :p to at least show it exactly as you'd have to assemble it with extension cable type A). But I'm sure excention cable type B exists just as much, which makes it work with the current rendering. Caveat emptor I would say. I'll open a MR with the correct rendering of the connector. But note, that ultimately, the PCB gerber is still the same as before!

oliv3r commented 1 year ago

https://github.com/absalom-muc/MHI-AC-Ctrl/pull/113

absalom-muc commented 1 year ago

I understand that the gerber is unchanged and that only the rendering is affected. But I've also seen in the last years that for unexperienced users this minor "inconsistency" creates confusion. Would it be possible to make a female connector and to rotate it by 180°? Then we are consistent to the existing assembly pictures. Thank you.

oliv3r commented 1 year ago

Then we are consistent to the existing assembly pictures I'd have to do some 3D modelling to create that connector :), which is not something I've done before much. So that's certainly a challenge :) So #113 puts it on the correct side, the 180degree rotation would then only be applicable because it's a female header. I'll see what I can do on those rendering skills. We could also omit the render of the connector for the time being :p

absalom-muc commented 1 year ago

Thank you for your efforts @oliv3r