search

abseil / abseil-cpp

Abseil Common Libraries (C++)
https://abseil.io
Apache License 2.0
14.9k stars 2.6k forks source link

Compilation fails if the current directory is in the include directory #1091

Open daemon opened 2 years ago

daemon commented 2 years ago

Describe the bug

absl/time/time.h masks time.h/ctime if the current directory is in the include directory. This happens if, say, $CPATH contains an empty directory.

Steps to reproduce the bug

$ export CPATH=/usr/include/:
$ gcc -xc++ -E -v -
...
#include <...> search starts here:
 .
 /usr/include/c++/7
...
$ cmake . && cmake --build .

What version of Abseil are you using?

c59e7e5.

What operating system and version are you using

Ubuntu 18.04.3 LTS.

What compiler and version are you using?

Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/7/lto-wrapper
OFFLOAD_TARGET_NAMES=nvptx-none
OFFLOAD_TARGET_DEFAULT=1
Target: x86_64-linux-gnu
Configured with: ../src/configure -v --with-pkgversion='Ubuntu 7.5.0-3ubuntu1~18.04' --with-bugurl=file:///usr/share/doc/gcc-7/README.Bugs --enable-languages=c,ada,c++,go,brig,d,fortran,objc,obj-c++ --prefix=/usr --with-gcc-major-version-only --program-suffix=-7 --program-prefix=x86_64-linux-gnu- --enable-shared --enable-linker-build-id --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --libdir=/usr/lib --enable-nls --enable-bootstrap --enable-clocale=gnu --enable-libstdcxx-debug --enable-libstdcxx-time=yes --with-default-libstdcxx-abi=new --enable-gnu-unique-object --disable-vtable-verify --enable-libmpx --enable-plugin --enable-default-pie --with-system-zlib --with-target-system-zlib --enable-objc-gc=auto --enable-multiarch --disable-werror --with-arch-32=i686 --with-abi=m64 --with-multilib-list=m32,m64,mx32 --enable-multilib --with-tune=generic --enable-offload-targets=nvptx-none --without-cuda-driver --enable-checking=release --build=x86_64-linux-gnu --host=x86_64-linux-gnu --target=x86_64-linux-gnu
Thread model: posix
gcc version 7.5.0 (Ubuntu 7.5.0-3ubuntu1~18.04)

What build system are you using?

cmake version 3.19.6

richard-vogl commented 2 years ago

This also happens when building any CMake project with abseil dependencies and set(CMAKE_INCLUDE_CURRENT_DIR ON)

ingomueller-net commented 1 year ago

I just ran into this trying to use abseil from an LLVM external project. LLVM is built with CMAKE_INCLUDE_CURRENT_DIR=ON. This took me forever to find. Maybe abseil should set CMAKE_INCLUDE_CURRENT_DIR=OFF in its CMakeLists.txt?