Open moubctez opened 4 years ago
Thank you for the suggestion. Since we don't actively try to support every platform, we take a passive approach to adopt any "harmless" patches. I think this patch seems fit in the category. However, please note that we don't have any test coverage for NetBSD and don't intend to add the coverage. That said, it would be ideal for you to test the patch on your platform to make sure it works and send us a PR. Otherwise, I can blindly apply the patch but won't have a way to verify its correctness. In addition, the second half of the change seems to be in cctz and Abseil regularly syncs with it, so you will need to open a PR in https://github.com/google/cctz.
NetBSD supports mmap() and pthread_getschedparam():
Also
_XOPEN_SOURCE
must not be defined, so either apply the following, or exclude defining it only for NetBSD (by the way, Darwin/macOS does not need either).