absinthe-graphql / absinthe_ecto

DEPRECATED: Use dataloader
MIT License
130 stars 36 forks source link

repo isn't on hex #12

Closed codestorm1 closed 7 years ago

codestorm1 commented 7 years ago

Hi, we broke our build today because the versions changed. Any reason this repo couldn't be hosted on hex.pm?

Thanks

benwilson512 commented 7 years ago

Hey!

I am placing it on hex now, it's mostly just an oversight.

Can you elaborate on how the build was broken? Your mix.lock file will lock both git dependencies as well as hex dependencies, so pushing additional code on our end won't force updates on your end.

codestorm1 commented 7 years ago

I'll mention this issue to my co-worker who had to break, maybe he can elaborate.

Thanks for adding it to Hex!

lvalencia commented 7 years ago

he's talking about our docker-build (or any build that runs mix deps.get) because it will get latests and the latest push had dependencies that we didn't meet, so we had to update our dependencies. It wasn't anything major but it was unexpected.

benwilson512 commented 7 years ago

Are you including the mix.lock file in your docker build? I was under the impression that even for git dependencies a mix deps.get would only get the locked git ref unless explicitly unlocked.

lvalencia commented 7 years ago

Yeah I understand what you're saying, the answer is I'm not sure man, we're using it as part of the edib package https://github.com/edib-tool/elixir-docker-image-builder if that helps.

benwilson512 commented 7 years ago

I would definitely try to figure out what dockerfile is being used by that tool. If your mix.lock file is not being included, you're gonna end up with a lot of bugs when libraries in production don't match libraries in development. In any case, we're on hex now.