search

absinthe-graphql / absinthe_ecto

DEPRECATED: Use dataloader
MIT License
130 stars 36 forks source link

Add initial test for ecto_batch/3 #20

Closed jsteiner closed 7 years ago

jsteiner commented 7 years ago

While the test is a bit more than a traditional unit test, I feel it's more valuable and more clear what is happening. Without calling perform_batch/2, it isn't really clear the purpose of the resulting tuple, and we won't have tested that these two functions play nicely together.

jsteiner commented 7 years ago

Eventual goal here is to get in a test for (and fix) #18

benwilson512 commented 7 years ago

This is fantastic. I think I may refactor out the use of ExMachina because it seems like I could just be passing structs to Repo.insert!