search

absmach / devops

DevOps scripts for Mainflux IoT platform
Apache License 2.0
23 stars 33 forks source link

MF-118 - Replace MF_NATS_URL with MF_BROKER_URL #120

Closed chen-dq closed 1 year ago

chen-dq commented 2 years ago

Signed-off-by: chen.dq chen.dq@neusoft.com

Resolves #118

chen-dq commented 2 years ago

sorry, I don't know what is the value of messageBrokerUrl such as messageBrokerUrl: "nats://broker:4222"

rodneyosodo commented 2 years ago

@manuio Should we make the messageBrokerUrl be configurable to nats, rabbitmq and possibly kafka or just use nats as the default broker

manuio commented 2 years ago

@manuio Should we make the messageBrokerUrl be configurable to nats, rabbitmq and possibly kafka or just use nats as the default broker

@0x6f736f646f I'd say that we should make it configurable and remove any hardcoded value from the charts. Not sure what to do with the {{ .Release.Name }}. Maybe we can have something like {{Values.defaults.msgBrokerProtocol}}://{{ .Release.Name }}-{{msgBrokerUrl}}:{{ .Values.defaults.msgBrokerPort }}. But it's a bit confusing and unreadable compared to {{messageBrokerUrl}} and a comment with the URLs that you can use :)

In any case I'd not change this untill we have support for all brokers.

arvindh123 commented 1 year ago

I also agree with @manuio point about not changing this until we have support for all brokers.