absmach / devops

DevOps scripts for Mainflux IoT platform
Apache License 2.0
23 stars 33 forks source link

NOISSUE - Fix invalid chart directory in `lint-test.yaml` #156

Closed JeffMboya closed 3 weeks ago

JeffMboya commented 1 month ago

What does this do?

This pull request fixes the issue where the provided chart directory was not being detected as a valid Helm chart directory during the ct lint step in the GitHub CI workflow.

Which issue(s) does this PR fix/relate to?

None

List any changes that modify/break current functionality

None

Have you included tests for your changes?

No

Did you document any new/modified functionality?

No

Notes

This is the received logs from the CI

Run ct lint --target-branch main --chart-dirs charts/magistrala/
Linting charts...
>>> helm version --template {{ .Version }}
>>> git rev-parse --is-inside-work-tree
>>> git rev-parse --verify origin/main
>>> git merge-base origin/main HEAD
>>> git diff --find-renames --name-only 277fe28b0343dafe56e8be88a69f5c8eec649e[18](https://github.com/absmach/magistrala/actions/runs/11127502755/job/30919951217?pr=103#step:9:19) -- charts/magistrala/
Directory "charts/magistrala" is not a valid chart directory. Skipping...
Directory "charts/magistrala" is not a valid chart directory. Skipping...
Directory "charts/magistrala" is not a valid chart directory. Skipping...
Directory "charts/magistrala" is not a valid chart directory. Skipping...
Directory "charts/magistrala" is not a valid chart directory. Skipping...
Directory "charts/magistrala/charts" is not a valid chart directory. Skipping...
Directory "charts/magistrala/templates" is not a valid chart directory. Skipping...
Directory "charts/magistrala/templates" is not a valid chart directory. Skipping...
Directory "charts/magistrala/templates" is not a valid chart directory. Skipping...
Directory "charts/magistrala/templates" is not a valid chart directory. Skipping...
Directory "charts/magistrala/templates" is not a valid chart directory. Skipping...
Directory "charts/magistrala/templates" is not a valid chart directory. Skipping...
Directory "charts/magistrala" is not a valid chart directory. Skipping...

------------------------------------------------------------------------------------------------------------------------
No chart changes detected.
------------------------------------------------------------------------------------------------------------------------
All charts linted successfully

This is the expected logs from the CI

Run ct lint --chart-dirs charts --target-branch main
Linting charts...

------------------------------------------------------------------------------------------------------------------------
 Charts to be processed:
------------------------------------------------------------------------------------------------------------------------
 magistrala => (version: "0.14.1", path: "charts/magistrala")
------------------------------------------------------------------------------------------------------------------------

Hang tight while we grab the latest from your chart repositories...
...Successfully got an update from the "magistrala-devops" chart repository
...Successfully got an update from the "nats" chart repository
...Successfully got an update from the "hashicorp" chart repository
...Successfully got an update from the "jaegertracing" chart repository
...Successfully got an update from the "bitnami" chart repository
Update Complete. ⎈Happy Helming!⎈
Saving 1 charts
Downloading magistrala from repo https://absmach.github.io/devops/
Deleting outdated charts
Could not verify charts/magistrala/charts/.gitignore for deletion: file 'charts/magistrala/charts/.gitignore' does not appear to be a gzipped archive; got 'application/octet-stream' (Skipping)
Linting chart "magistrala => (version: \"1.0.0\", path: \"charts/magistrala\")"
Checking chart "magistrala => (version: \"1.0.0\", path: \"charts/magistrala\")" for a version bump...
Unable to find chart on main. New chart detected.
Validating /home/runner/work/magistrala/magistrala/charts/magistrala/Chart.yaml...
Validation success! 👍
Validating maintainers...
==> Linting charts/magistrala

1 chart(s) linted, 0 chart(s) failed

------------------------------------------------------------------------------------------------------------------------
 ✔︎ magistrala => (version: "1.0.0", path: "charts/magistrala")
------------------------------------------------------------------------------------------------------------------------
All charts linted successfully