absmach / magistrala-ui

UI Repository for Magistrala IoT

10 stars 17 forks source link

MG-164 - Add input validation to chart modals #193

Closed felixgateru closed 6 months ago

felixgateru commented 7 months ago

What type of PR is this?

[ ] Refactor
[x] Feature
[ ] Bug Fix
[ ] Optimization
[ ] Documentation Update
[ ] Dependency Update

What does this do?

Adds input validation to the forms present in the create chart modals.

Which issue(s) does this PR fix/relate to?

Related Issue #164

Have you included tests for your changes?

[ ] Yes
[x] No, and this is why:

Did you document any new/modified functionality?

[ ] Yes
[x] No, and this is why:

Notes

ianmuchyri commented 7 months ago

It shouldn't be showing the green tick if the time is wrong

Also, make sure both the start time and end time are not greater than the now() time. You can find a way of disabling any time that is greater than now() from being selected, or validate it afterward.