absmach / magistrala-ui

UI Repository for Magistrala IoT
9 stars 15 forks source link

NOISSUE - Abstract list data-structure on input form #32

Closed SammyOina closed 8 months ago

SammyOina commented 9 months ago

What type of PR is this?

What does this do?

Allows input of list items in a user-friendly way without revealing the underlying datastructure

Which issue(s) does this PR fix/relate to?

None

Have you included tests for your changes?

Did you document any new/modified functionality?

Notes

image

This could also be used for metadata input

ianmuchyri commented 8 months ago

It shouldn't reflect if a user presses the enter button without having any data as shown below image

Those dots are if I press the enter button without having any tags

ianmuchyri commented 8 months ago

for some reason now, I can't delete the tags by clicking on them

ianmuchyri commented 8 months ago

There is no more color image

ianmuchyri commented 8 months ago

also check why in this modal, it does not work as intended. I cannot see the tags at the top image

dborovcanin commented 8 months ago

Please rebase.

SammyOina commented 8 months ago

Please rebase.

@dborovcanin I have rebased

SammyOina commented 8 months ago

Please rebase.

@dborovcanin I have rebased

SammyOina commented 8 months ago

Let's do it also when updating tags

image

Updates use tables it's a bit different and would require a separate PR

rodneyosodo commented 8 months ago

Let's do it also when updating tags

Updates use tables it's a bit different and would require a separate PR

Can you create an issue for that