absolllute / Mega-Hack-Pro-Future

Mega Hack Pro Suggestion & Issue Tracker
40 stars 5 forks source link

Repo/Tracker Improvements [Mega Issue] #431

Open Brittank88 opened 2 years ago

Brittank88 commented 2 years ago

This rolls in #423, #378, #159 into a single issue, and allows for discussion and the addition of potential improvements to the following checklist, via edits I will make whenever a new improvement is approved:

Brittank88 commented 2 years ago

[ ] ((Meta) Issue Tracker Suggestions #423 (comment)) Compiled list (See: (Meta) Issue Tracker Suggestions #423 (comment), (Meta) Issue Tracker Suggestions #423 (comment)) of all added features that were suggested by users on the tracker in the README.md so new users will see how the community is helping MH grow.

Thinking it would be good for each entry to link to the logged issue that resulted in its implementation. Thoughts?

Nicko2102 commented 2 years ago

from #389 i think this (added label) could also be implemented as part of #423, as a way to track those sort of things on github. Also, to make it cleaner, there could be an "added" label alongside a "ready label", or something like that, although that seems like it might be a bit too much work...

MainConMan commented 2 years ago

[ ] ((Meta) Issue Tracker Suggestions #423 (comment)) Compiled list (See: (Meta) Issue Tracker Suggestions #423 (comment), (Meta) Issue Tracker Suggestions #423 (comment)) of all added features that were suggested by users on the tracker in the README.md so new users will see how the community is helping MH grow.

Thinking it would be good for each entry to link to the logged issue that resulted in its implementation. Thoughts?

I like this idea! I don't see any reason not to do this.

Brittank88 commented 2 years ago

from #389 i think this (added label) could also be implemented as part of #423, as a way to track those sort of things on github. Also, to make it cleaner, there could be an "added" label alongside a "ready label", or something like that, although that seems like it might be a bit too much work...

I also like this (Edit: Have just added it to the list). Yes, it will take effort to go find every implemented issue and apply the "Added" label to it, but it would be worth it, and it could disambiguate between something being "approved" and actually making its way into a release (because it seems that those on a Venn diagram are indeed not a circle...).

@MainConMan You made that original list of features that have since been implemented - is that everyone? I'd be surprised if it was considering we've passed the 400 issue mark, but if so then fair enough. I'd just like to not be on my own in finding every issue that would need this label applied to it.

Brittank88 commented 2 years ago

Also, I found this, it could be a good way to automatically list people whose input has resulted in implemented features: https://allcontributors.org/

MainConMan commented 2 years ago

@MainConMan You made that original list of features that have since been implemented - is that everyone? I'd be surprised if it was considering we've passed the 400 issue mark, but if so then fair enough. I'd just like to not be on my own in finding every issue that would need this label applied to it.

The list didnt include bugs, only enhancements, but it was every added enhancement I could find. Would it be helpful if I were to make a list with links? And if so, would you want me to include bugs (or any other label)?

Edit: I forgot to mention this, and I probably should, but the first 3 issues by Absolute I did not include.

Brittank88 commented 2 years ago

Would it be helpful if I were to make a list with links?

This would be so wonderful!

And if so, would you want me to include bugs (or any other label)?

As a separate list, that would be very cool!

Please don't feel obligated to do it though, you've been super helpful already and I can't thank you and others (Zohnannor, Nicko2102, etc. looking at you guys ❤️) enough.

I forgot to mention this, and I probably should, but the first 3 issues by Absolute I did not include.

Yeah, if this list is for crediting and showing off the contributions of those in the community, including Absolute's own issues doesn't make much sense.

MainConMan commented 2 years ago

Alright, I'll make a separate list, and include all issues regardless of labels. I'll start when I get home, and update this message with my progress! :)

Edit: I worded this in a weird way. For clarification, im going to go through all issues, and make an "Added Enhancements" list, a "Fixed Bugs" list, and possibly a 3rd list for issues that dont fit into the other 2, if that's even needed.

I hope this makes sense, if anyone has questions, feel free to ask me :)

Update 1: Started working on the lists during my lunch break because I was bored. Stopped at issue 29.

Update 2: Finished! It took me about 3 hours in total, which is less time than I thought it would tbh :D

MainConMan commented 2 years ago

I finished the lists! There seems to be a lot more enhancements then on the last list, I guess it's because of how I sorted the issues to make the last list. I'm very sorry about that. This time, I went through EVERY issue, so that won't be a problem this time!

MHv7 Issue Tracker Thing.txt

Enhancements

Person/s Description Issue # Update Added Notes
Brittank88 Z-Layer 0 Bypass #6 V6.2 beta3
Brittank88 Mouse Becomes Visible When Overlay is Open #9 V6.1 GM1
Brittank88 Rotation Modifier #10 V6.2 beta3
WEGfan Practice Pickup Coins #12 V6.2 beta3
Brittank88 No Respawn Flash #19 V6.2 beta3
Conlinkin Coins Show Uncollected #20 V6.2 beta3
Brittank88 Start Pos Lag Fix #22 V7 beta3/4
Fl1pNatic & Brittank88 Cheat Indicator #24 V6.2 beta3
zohnannor Tooltips #29 V6.3 beta5
Brittank88 Unfocused FPS #30 V7 beta1
Brittank88 Behaviour of "NoClip Accuracy" #33 V7 beta1
Brittank88 Dynamic Menu Length #34 V6.3 beta4
jojo989 Classic Speed Hack #37 V6.3 beta1
Wukarditd Disable Hide Trigger #55 V7 beta1
gggeo0513 Auto Pickup Coins #63 V7 beta1
Aktimoose Icon Level Colours #73 V7 beta1
Brittank88 Granular Extension / Absolutedlls Load Order #81 V7 beta1
Fl1pNatic NoClip Deaths #83 V7 beta1
Fl1pNatic Experimental NoClip Accuracy #84 V7 beta1
Brittank88 Hide UI Doesn't Hide Link Buttons #87 V7 beta1
Brittank88 Hide UI // BetterEdit Compatibility #90 V7 beta1
pHellowWorld Void Click Bug Fix #96 V7 beta1
AdyaGD Change Colours of 2nd Dual Icon #105 V7 beta1
RealBikas 0% Practice Complete #106 V7 beta1
patrykchrymecki Better Safe Mode #121 V7 beta1
Fl1pNatic NoClip Accuracy Damage Tint Colour #127 V7 beta1
patrykchrymecki Hitbox Colour Customization #128 V7 beta1
alexmalex2007 Low Detail Option #131 V7 beta1
LinkeddGD Colour 1 / Colour 2 Pulse w/ BG / Pastel #133 V7 beta1
Md915 Hide Pause Layer #140 V7 beta1
Yuukinoo Mute on Unfocus #143 V7 beta1
BlockOG Show Layout #148 V7 beta1
Brittank88 Pause During Complete #152 V7 beta5/6
Brittank88 Input Box Copy/Paste Support #153 V7 beta1
Joel055 "Uncomplete Level" Reset Orbs/Coins #163 V7 beta1 Resets orbs, but not coins. Not 100% sure on Update Added.
Fl1pNatic Blending Modes For Colour Options (+ P1 / P2 Swap) #167 V7 beta1
NewAlexGamer Favourites Tab #168 V7 beta1
Fl1pNatic Make Pressing Space on Level Complete Screen Start The Level Over #208 V7 beta2
GDSaneS Legit Indicator #210 V7 beta3
fedqq Better Start Pos Switcher #272 V7 beta5/6 Points 3 and 4 added, 1 and 2 not added.
Fl1pNatic Make "Session Time" Status Run in Real Time #273 V7 beta5/6
MainConMan Last Death Status #274 V7 beta5/6 Added in MHv7-beta5, but replaced for "best run" in MHv7-beta6.
MainConMan Stop Move Triggers on Death #286 V7 GM1
BrownieGamingX5 Set Labels/Status Opacity #304 V7 GM1

Bugs

Person/s Description Issue # Update Added Notes
Brittank88 "Hide UI" Option Requires Editor Pause Toggle #4 V7 beta1
Brittank88 Set Scale Doesn't Support Negatives #17 V6.2 beta3 Not 100% sure on update added.
Brittank88 Borderless Fullscreen Fails #31 V6.2 GM1 -
CoolDawg08 Random Game Freezing #44 V7 beta1 -
NEM3S Solid Colour Failure #53 V6.3 beta5 -
dyfw Instant Complete Crash w/ 2-Player Start #56 V7 beta1 -
Fliare Death Effect Always Disabled #61 V6.3 beta5 -
OctahedronV2 NoClip Accuracy Doesn't Activate Cheat Indicator #65 V7 beta1 -
Aktimoose Auto Music Sync + Practice Music Hack #101 V7 beta1 -
VIKI155 CPS Counter Doesn't Work With Bots #108 V7 beta1 -
patrykchrymecki CPS Counter Showing in Keybinds #122 V7 beta1 -
Brittank88 Full-Height Menu Bug #158 V7 beta1 -
patrykchrymecki Show Hitboxes Crash #175 V7 beta1 -
NewAlexGamer Multiple Hacks/Mods Cannot be Set on The Same Key #177 V7 beta5 -
NewAlexGamer "Set Scale" Doesn't Save #179 V7 beta5 -
NewAlexGamer "Auto Music Sync" Game Freeze on Level Exit #181 V7 beta5 -
KitKat63916 Run Extension Overlaps #188 V7 beta4 -
sinc0s Using StartPos Switcher in Normal Mode Crashes Game #190 V7 beta2 -
KitKat63916 Typing Messages Triggers Keybinds #192 V7 beta5 -
Nicko2102 NoClip Accuracy Overridden by 0% Practice #198 V7 beta3/4 Not 100% sure on update added.
noeruchangd Lock Cursor Not Working #200 V7 beta4 -
noeruchangd Toggle For Free Window Resize And/or Save Resolution Settings #202 V7 beta4 -
noeruchangd Level Complete Screen & StartPos Switcher #203 V7 beta2 -
patrykchrymecki Toggling % in Pause Menu Sets in Game Clock to 00:00:00 #204 V7 beta3 -
patrykchrymecki Tint on Death Enables Experimental #205 V7 beta2 -
mrhotmadm Rainbow Icon fails on Robot And Spider #211 V7 beta2 -
Fl1pNatic Game is Extremely Unstable #216 V7 beta2/3 -
dankmeme01 Wrong Tooltip for "Auto Song Download" #217 V7 beta3 -
kenar-f CPS/FPS Display Broken #218 V7 beta4 -
CreeperSword Phantom Wave Trail #224 V7 beta4 -
CyberCat30 Music Flash Green And Blue Channels Swap #225 V7 beta4 -
dankmeme01 Slope Physics Bug w/ NoClip #228 V7 beta3 -
ImmensityHQ Respawn at Last Checkpoint Doesn't Hide Mouse #230 V7 beta4 -
zohnannor "Player Trail" Does Nothing #245 V7 beta6 -
zohnannor "Fill Hitbox" Multiple Application Bug #246 V7 beta5/6 -
Sloweneuh Dash Orb Fire, Robot/Spider Glow Are Secondary Colour/Glow Even if Those Are RGB #247 V7 beta5 -
NewAlexGamer "Disable In Editor" Works After Clicking Save And Play #248 V7 beta5 -
NewAlexGamer Speedhack Value Resetting #250 V7 beta5 -
totallyphysicallypossible NoClip Enables Itself After Restart #255 V7 beta5 -
NewAlexGAmer "Disable In Editor" Not Working #282 V7 beta5 -
Aktimoos Icon Effects Don't Work on Spider or Robot Glows #289 V7 beta5 Dupe of #247.
BrownieGamingX5 Speedhack Resets Back To 1x #291 V7 beta5 Dupe of #250.
totallyphysicallypossible Can't Paste in MH Text Inputs #293 V7 GM1 -
totallyphysicallypossible Best Run Updates When Using NoClip #295 V7 GM1 -
SadShikawa Icon Hack Doesn't Save Icons #296 V7 beta5 Fixed before issue was created.
Fl1pNatic "Icons" Module Doesn't Work #311 V7 beta5 Dupe of #296.
TheTruePringle Random Icons Seems Predetermined #318 V7 GM1 -
NewAlexGamer "Best Run" Text Doesn't Show Runs to 100% #319 V7 GM1 -
BrownieGamingX5 X/Y/Z Variable Object Edit Delete #320 V7 GM1 -
BrownieGamingX5 Speedhack Game Crash Reset #352 V7 GM1 -
Nicko2102 Erebus Positioning? #375 N/A -

Other

Person/s Description Issue # Update Added Notes
Brittank88 absolllute.com/contact References The Tracker #35 N/A -
patrykchrymecki Transition Customizer #103 V7 beta1 Brought back from MHv5.
benjaYTn Gifting System #157 N/A -
zohnannor RGB Icons Speed #180 V7 beta4 Brought back from MHv6.
feytox Thread Priority #215 V7 beta2 Brought back from MHv6.
patrykchrymecki Website Still Says "Mega Hack v6 Pro" #223 N/A -
patrykchrymecki Website Displays Wrong Title #265 N/A -
patrykchrymecki Website Shows Wrong Text #275 N/A -

(Tabulated by @Brittank88 😄)

Notes: I did not include the first 3 issues by Absolute. I didn't Include Issue #18, If you want me to add it, I can update my message. :)

Brittank88 commented 2 years ago

This time, I went through EVERY issue

Are you sure you didn't descend down from the heavens you are a god wtf thank you

Brittank88 commented 2 years ago

@absoIute Idea I just had - if we actually make use of the milestones feature we can much more easily track which issues went into which update. We just make a new milestone for each new update version, and add issues to it as they become upcoming. This actually removes the need for the upcoming label, as we inherently know they're upcoming by the fact that they are present in the milestone.

Would love to know what everyone else thinks of this too!

MainConMan commented 2 years ago

Are you sure you didn't descend down from the heavens you are a god wtf thank you

Happy to help! :)

Brittank88 commented 2 years ago

(Dupe of 153?)

Technically not - one was implementing for the extensions API, whilst the other was a bug in the default input boxes. I'd consider them separate.

(Dupe of 247?) (dupe of 250?) (Dupe of 296?)

I think you're correct on these. Have marked them as duplicates just to be thorough.

Let me know if I missed any other dupes you noted!

MainConMan commented 2 years ago

(Dupe of 153?)

Technically not - one was implementing for the extensions API, whilst the other was a bug in the default input boxes. I'd consider them separate.

(Dupe of 247?) (dupe of 250?) (Dupe of 296?)

I think you're correct on these. Have marked them as duplicates just to be thorough.

Let me know if I missed any other dupes you noted!

I think that's all of them. Should I edit my message to remove the 3 that were? Or should I just leave them in?

Brittank88 commented 2 years ago

Leave them in - btw I'm gonna edit your message very soon with it all formatted into a nice markdown table!

Awarest-Align is such a cool VSCode extension, it made this process so much quicker.

MainConMan commented 2 years ago

btw I'm gonna edit your message very soon with it all formatted into a nice markdown table!

Good idea! Thanks :)

Nicko2102 commented 2 years ago

@absoIute Idea I just had - if we actually make use of the milestones feature we can much more easily track which issues went into which update. We just make a new milestone for each new update version, and add issues to it as they become upcoming. This actually removes the need for the upcoming label, as we inherently know they're upcoming by the fact that they are present in the milestone.

Would love to know what everyone else thinks of this too!

Love this idea, honestly if it makes things easier for everyone then i'm all for it

Nicko2102 commented 2 years ago

MHv7 Issue Tracker Thing.txt

could have sworn i had more than 2 things 🤔

MainConMan commented 2 years ago

MHv7 Issue Tracker Thing.txt

could have sworn i had more than 2 things 🤔

It only includes things that are already implemented (as of v7 gm1), that's probably why.

MainConMan commented 2 years ago

The table looks so much better than what I had originally. Good job Brittank!

Brittank88 commented 2 years ago

MHv7 Issue Tracker Thing.txt

could have sworn i had more than 2 things 🤔

It only includes things that are already implemented (as of v7 gm1), that's probably why.

Probably for the best - trying to dig all the way back to MHv6 would be a big project in itself.

Brittank88 commented 2 years ago

The table looks so much better than what I had originally. Good job Brittank!

I know when you go to edit it, it looks kinda broken, but that's just because the lines are too long. Wish this thread took advantage of how wide PC screens usually are. Maybe I can author a Tampermonkey extension to fix that.

Nicko2102 commented 2 years ago

MHv7 Issue Tracker Thing.txt

could have sworn i had more than 2 things 🤔

It only includes things that are already implemented (as of v7 gm1), that's probably why.

oh right lol

MainConMan commented 2 years ago

MHv7 Issue Tracker Thing.txt

could have sworn i had more than 2 things 🤔

It only includes things that are already implemented (as of v7 gm1), that's probably why.

Probably for the best - trying to dig all the way back to MHv6 would be a big project in itself.

I may be misinterpreting, but it does include things added from all updates. I meant that the list doesn't include any issues if they haven't been added.

Nicko2102 commented 2 years ago

MHv7 Issue Tracker Thing.txt

could have sworn i had more than 2 things 🤔

It only includes things that are already implemented (as of v7 gm1), that's probably why.

Probably for the best - trying to dig all the way back to MHv6 would be a big project in itself.

I may be misinterpreting, but it does include things added from all updates. I meant that the list doesn't include any issues if they haven't been added.

I think Brittank might have misunderstood actually, i think you were clarifying that you aren't including any "upcoming" hacks

Brittank88 commented 2 years ago

Maybe I can author a Tampermonkey extension to fix that.

Just wrote this line which you can add to your blocklist in uBlock Origin to fix this! github.com##div.container-xl:style(max-width: calc(100vw - 128px) !important)

You can adjust the 128px to increase/decrease the overall width of everything.

MainConMan commented 2 years ago

The table looks so much better than what I had originally. Good job Brittank!

I know when you go to edit it, it looks kinda broken, but that's just because the lines are too long. Wish this thread took advantage of how wide PC screens usually are. Maybe I can author a Tampermonkey extension to fix that.

Lmao, yeah. It shouldn't be too hard to work around if one of us ever needs to. NVM as I was typing this you found a fix!

Brittank88 commented 2 years ago

NVM as I was typing this you found a fix!

Fix part two: Forcing a monospaced font within the comment edit textarea with the following line:

github.com##textarea.comment-form-textarea:style(font-family: 'Courier New', monospace !important)

This is the one that also really messes with Markdown table alignment.

Brittank88 commented 2 years ago

image

SO MUCH BETTER

Brittank88 commented 2 years ago

(Seriously I recommend uBlock Origin regardless it's really good at blocking certain things that are typically hard to block - for example, it can actually remove classes from HTML elements which bypasses some no-scroll stuff on websites).

MainConMan commented 2 years ago

(Seriously I recommend uBlock Origin regardless it's really good at blocking certain things that are typically hard to block - for example, it can actually remove classes from HTML elements which bypasses some no-scroll stuff on websites).

Already have it installed! Thanks! :D

MainConMan commented 2 years ago

MHv7 Issue Tracker Thing.txt

I was reading over this 1 more time, and found a mistake I made. #364 should have upcoming label, and should be removed from the table. Very sorry about that.

I will update the table to remove it when I get home, unless Brittank or Absolute do it before then.

edit: its updated now 👍

Nicko2102 commented 2 years ago

also for # 198 can you capitalize my name? ik its a small thing but its capital in the other row so it looks a little off thanks :D also can i nominate MainConMan for repo collaborator if you ever need another one, he's done a lot to make things better and easier for everyone lol

MainConMan commented 2 years ago

also for # 198 can you capitalize my name? ik its a small thing but its capital in the other row so it looks a little off thanks :D

Yes I will, and I'll also fix any other spelling/capitalization error I find!

absoIute commented 2 years ago

@absoIute Idea I just had - if we actually make use of the milestones feature we can much more easily track which issues went into which update. We just make a new milestone for each new update version, and add issues to it as they become upcoming. This actually removes the need for the upcoming label, as we inherently know they're upcoming by the fact that they are present in the milestone.

Would love to know what everyone else thinks of this too!

will start to do this ngl sounds good, will go through previous updates too

absoIute commented 2 years ago

Also, I found this, it could be a good way to automatically list people whose input has resulted in implemented features: https://allcontributors.org/

added the bot! that's one hell of a list

Brittank88 commented 2 years ago

also for # 198 can you capitalize my name? ik its a small thing but its capital in the other row so it looks a little off thanks :D also can i nominate MainConMan for repo collaborator if you ever need another one, he's done a lot to make things better and easier for everyone lol

Hey, don't discredit yourself either! Absolute and I have noticed both of your contributions, alongside Zohnannor too. I actually credited you guys in a Twitter post. ❤️

The permission system here is kinda weird and limited so unless we add you as contributors at an identical level to my own permission set, there isn't much we can do. Maybe migrating to a self-hosted issue tracker will provide a more granular permissions/roles system?

MainConMan commented 2 years ago

Hey, don't discredit yourself either! Absolute and I have noticed both of your contributions, alongside Zohnannor too.

Also NewAlexGamer, he has had a lot of good suggestions here too!

I actually credited you guys in a Twitter post. ❤️

TYSM! This genuinely means a lot to me! :)

The permission system here is kinda weird and limited so unless we add you as contributors at an identical level to my own permission set, there isn't much we can do. Maybe migrating to a self-hosted issue tracker will provide a more granular permissions/roles system?

If that's the case, then I understand if Absolute decides not to add any other contributors.

Nicko2102 commented 2 years ago

I actually credited you guys in a Twitter post. ❤️

thank you, that means so much :D

The permission system here is kinda weird and limited so unless we add you as contributors at an identical level to my own permission set, there isn't much we can do. Maybe migrating to a self-hosted issue tracker will provide a more granular permissions/roles system?

It might, but github seems to be working well for this, and I don't want to move the whole tracker just for a role, I'm happy to help the same way i have been so far

MainConMan commented 2 years ago

The permission system here is kinda weird and limited so unless we add you as contributors at an identical level to my own permission set, there isn't much we can do. Maybe migrating to a self-hosted issue tracker will provide a more granular permissions/roles system?

It might, but github seems to be working well for this, and I don't want to move the whole tracker just for a role, I'm happy to help the same way i have been so far

Moving the tracker was an idea before this was mentioned, so it's possible that there would be more benefits to this, I'm not sure. But I do agree that it shouldn't be moved if the only thing to gain from it is a role.

Brittank88 commented 2 years ago

It might, but github seems to be working well for this, and I don't want to move the whole tracker just for a role, I'm happy to help the same way i have been so far

Moving the tracker was an idea before this was mentioned, so it's possible that there would be more benefits to this, I'm not sure. But I do agree that it shouldn't be moved if the only thing to gain from it is a role.

You guys are truly wonderful. We mainly were considering migrating to a self-hosted tracker on Absolute's servers because it's then all within his own ecosystem, it's potentially much more flexible, it might allow me to contribute with the same level of permissions as Absolute (this is currently impossible for some dumb reason), etc.

So there's a bunch of good reasons, even putting aside giving you guys the credit you deserve! 😋

MainConMan commented 2 years ago

Would it be helpful if I added an "Update Added" column to the table Brittank and I made? It shouldn't be too much effort for me to add it, the hardest part for me will probably be getting another column in the table lol.

Nicko2102 commented 2 years ago

Moving the tracker was an idea before this was mentioned, so it's possible that there would be more benefits to this, I'm not sure. But I do agree that it shouldn't be moved if the only thing to gain from it is a role.

oh really i didnt know that lol

Would it be helpful if I added an "Update Added" column to the table Brittank and I made? It shouldn't be too much effort for me to add it, the hardest part for me will probably be getting another column in the table lol.

yes that would be great, I think it will make transitioning to the BookStack thing (or whatever the mane is i forget) quite a lot easier

zohnannor commented 2 years ago

I actually credited you guys in a Twitter post. ❤️

Wow, thank you! It means a lot! Always happy to help! :)

The permission system here is kinda weird and limited so unless we add you as contributors at an identical level to my own permission set, there isn't much we can do.

Totally understand, We are doing well even without it I think :)

MainConMan commented 2 years ago

Would it be helpful if I added an "Update Added" column to the table Brittank and I made? It shouldn't be too much effort for me to add it, the hardest part for me will probably be getting another column in the table lol.

Did this, and finished finding and adding the updates in "Enhancements" and "Other", I'll finish the rest tomorrow. :)

MainConMan commented 2 years ago

Would it be helpful if I added an "Update Added" column to the table Brittank and I made? It shouldn't be too much effort for me to add it, the hardest part for me will probably be getting another column in the table lol.

Did this, and finished finding and adding the updates in "Enhancements" and "Other", I'll finish the rest tomorrow. :)

I finished everything else!!! Also, I found another mistake I made, #297 isn't fixed yet, it needs the upcoming label. So sorry about this. I know everything else is correct though, because I went through and added all updates! :)