Add missing return value for Command's execute() methods (Symfony >= 4.4)

absolute-quantum / DoctrineEncryptBundle

:key: Encrypted symfony entities by verified and standardized libraries

https://packagist.org/packages/michaeldegroot/doctrine-encrypt-bundle

MIT License

143 stars 74 forks source link

Add missing return value for Command's execute() methods (Symfony >= 4.4) #48

Open sebb opened 3 years ago

sebb commented 3 years ago

Fixes:

Return value of "Ambta\DoctrineEncryptBundle\Command\DoctrineEncryptStatusCommand::execute()" must be of the type int, "null" returned. when using Symfony 5

Similar to https://github.com/GiveMeAllYourCats/DoctrineEncryptBundle/pull/41 with the reviewers' suggestions implemented.

tikoflano commented 3 years ago

It would probably be better not to use self::FAILURE and self::SUCCESS but rather 1 and 0 in order to still support versions of Symonfy < 5.1

r3hp1c commented 1 year ago

Similar to another pull request that that were copied: https://github.com/DoctrineEncryptBundle/DoctrineEncryptBundle/pull/4

Please see these comments:

The new package that I hope will be maintained by more than 1 person