search

absolute-version / commit-and-tag-version

Fork of the excellent standard-version. Automate versioning and CHANGELOG generation, with semver.org and conventionalcommits.org :trophy:
ISC License
385 stars 36 forks source link

fix: preserve frontmatter when updating changelog #108

Closed TimKnight-DWP closed 10 months ago

TimKnight-DWP commented 10 months ago

fixes: #106

TimKnight-DWP commented 10 months ago

I'll have a look at these failing tests

TimothyJones commented 10 months ago

Thanks! Sorry about the lint settings. Every time I work on this, I'm tempted to replace the format rules with default prettier settings, but I didn't really want to fork it and then go "ok here are all my opinions", you know? :)

You may also want to merge in master again - speaking of lint settings, I realised that some of the tests weren't actually running, due to dangling promises. So I updated those with some defaults designed to prevent tests that don't do what is expected.

I've enabled the "update branch" button to make this easy.

TimKnight-DWP commented 10 months ago

To be fair, I think moving to some Default Prettier settings would make sense, at least they are a default set of opinions used across tech 😄

TimothyJones commented 10 months ago

Good point, prettier has definitely won out. I'm convinced.

I reckon I'll do it after this, #99 and #109 have landed - I don't want to stamp on the toes of people currently in the middle of contributing.

TimKnight-DWP commented 10 months ago

Awesome.

TimKnight-DWP commented 10 months ago

Could've sworn I had run "fix" before pushing, but hey ho.

All done now

TimothyJones commented 10 months ago

Thanks again! Releasing as 12.0.0 (since I also dropped node 14 and 16)

TimKnight-DWP commented 10 months ago

Thanks Tim, I'll keep an eye out and integrate 12.0.0 into our pipelines as and when